From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=3.0 tests=DATE_IN_PAST_96_XX, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E162C4CEC9 for ; Wed, 18 Sep 2019 15:36:59 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7681B21907 for ; Wed, 18 Sep 2019 15:36:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="E4fWNhKq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7681B21907 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5A7A9166F; Wed, 18 Sep 2019 17:36:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5A7A9166F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1568821016; bh=6UuiD55U6YwmvPJUC3I8FgELkMDK6XkKAL5y/zFdCKg=; h=Date:From:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=E4fWNhKqkmRtqBLTgNg67LZORMEU8In83uD8uRYTtwd+rrguAEbo62gROkza5e51Q +wm6pstiBzhLctjWzs/g5/Igh6BvKkBNk5pFnugwRM3mNpyYG5cZQBihPGFBIRVKHV lmgDo8JwDwbQhSvid8cH6BKCVAk4MJsmJ6+1Jp9U= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D95A4F804FF; Wed, 18 Sep 2019 17:36:05 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6D639F80506; Wed, 18 Sep 2019 17:36:04 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3AD64F80146 for ; Wed, 18 Sep 2019 17:36:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3AD64F80146 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 08:35:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,521,1559545200"; d="scan'208";a="338362191" Received: from gliakhov-mobl2.ger.corp.intel.com (HELO ubuntu) ([10.249.33.135]) by orsmga004.jf.intel.com with ESMTP; 18 Sep 2019 08:35:56 -0700 Date: Tue, 10 Sep 2019 11:20:17 +0200 From: Guennadi Liakhovetski To: alsa-devel@alsa-project.org Message-ID: <20190910092016.GA6821@ubuntu> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Mark Brown , Liam Girdwood Subject: [alsa-devel] DPCM: suspicious code in dpcm_prune_paths() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi, This code in dpcm_prune_paths() seems to have no effect: /* is there a valid CODEC DAI widget for this BE */ for_each_rtd_codec_dai(dpcm->be, i, dai) { widget = dai_get_widget(dai, stream); /* prune the BE if it's no longer in our active list */ if (widget && widget_in_list(list, widget)) continue; } Neither of the variables, that are modified in this loop are used outside of it. Was the "continue" maybe meant to continue the encompassing loop? Thanks Guennadi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel