From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Eugene Syromiatnikov <esyr@redhat.com>,
Christian Brauner <christian@brauner.io>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Eric Biederman <ebiederm@xmission.com>,
Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH] fork: fail on non-zero higher 32 bits of args.exit_signal
Date: Tue, 10 Sep 2019 15:20:31 +0300 [thread overview]
Message-ID: <20190910122031.GA5311@altlinux.org> (raw)
In-Reply-To: <20190910115711.GA3755@asgard.redhat.com>
On Tue, Sep 10, 2019 at 12:57:11PM +0100, Eugene Syromiatnikov wrote:
> Previously, higher 32 bits of exit_signal fields were lost when
> copied to the kernel args structure (that uses int as a type for the
> respective field). Fail with EINVAL if these are set as it looks like
> there's no sane reason to accept them.
>
> * kernel/fork.c (copy_clone_args_from_user): Fail with -EINVAL if
> args.exit_signal converted to unsigned int is not equal to the original
> value.
>
> Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
Reviewed-by: Dmitry V. Levin <ldv@altlinux.org>
--
ldv
next prev parent reply other threads:[~2019-09-10 12:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 11:57 [PATCH] fork: fail on non-zero higher 32 bits of args.exit_signal Eugene Syromiatnikov
2019-09-10 12:20 ` Dmitry V. Levin [this message]
2019-09-10 12:44 ` Oleg Nesterov
2019-09-10 13:09 ` Christian Brauner
2019-09-10 13:10 ` Christian Brauner
2019-09-10 13:27 ` Christian Brauner
2019-09-10 14:27 ` Eugene Syromiatnikov
2019-09-10 14:39 ` Oleg Nesterov
2019-09-10 14:46 ` Christian Brauner
2019-09-10 15:18 ` Eugene Syromiatnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190910122031.GA5311@altlinux.org \
--to=ldv@altlinux.org \
--cc=akpm@linux-foundation.org \
--cc=christian@brauner.io \
--cc=ebiederm@xmission.com \
--cc=esyr@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.