From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 5/8] drm/i915: Consolidate {bxt, cnl, icl}_uninit_cdclk Date: Tue, 10 Sep 2019 15:39:45 +0300 Message-ID: <20190910123945.GK7482@intel.com> References: <20190907002143.22591-1-matthew.d.roper@intel.com> <20190907002143.22591-6-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 15FA289FD3 for ; Tue, 10 Sep 2019 12:39:49 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190907002143.22591-6-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBTZXAgMDYsIDIwMTkgYXQgMDU6MjE6NDBQTSAtMDcwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBUaGUgdW5pbml0aWFsaXplIGZsb3cgaXMgdGhlIHNhbWUgb24gYWxsIG9mIHRoZXNlIHBs YXRmb3JtcywgYXNpZGUgZnJvbQo+IGNhbGN1bGF0aW5nIGEgZGlmZmVyZW50IGZyZXF1ZW5jeSBs ZXZlbC4KPiAKPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwu Y29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2NkY2xrLmMg fCA0OCArKysrKysrLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRp b25zKCspLCAzNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvZGlzcGxheS9pbnRlbF9jZGNsay5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxh eS9pbnRlbF9jZGNsay5jCj4gaW5kZXggZjhjMmE3MDY5OTBiLi5hNzBmZWM4MmQyYmMgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9jZGNsay5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9jZGNsay5jCj4gQEAgLTE2OTIs NyArMTY5MiwxOCBAQCBzdGF0aWMgdm9pZCBieHRfdW5pbml0X2NkY2xrKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdikKPiAgCj4gIAljZGNsa19zdGF0ZS5jZGNsayA9IGNkY2xrX3N0 YXRlLmJ5cGFzczsKPiAgCWNkY2xrX3N0YXRlLnZjbyA9IDA7Cj4gLQljZGNsa19zdGF0ZS52b2x0 YWdlX2xldmVsID0gYnh0X2NhbGNfdm9sdGFnZV9sZXZlbChjZGNsa19zdGF0ZS5jZGNsayk7Cj4g KwlpZiAoSVNfRUxLSEFSVExBS0UoZGV2X3ByaXYpKQo+ICsJCWNkY2xrX3N0YXRlLnZvbHRhZ2Vf bGV2ZWwgPQo+ICsJCQllaGxfY2FsY192b2x0YWdlX2xldmVsKGNkY2xrX3N0YXRlLmNkY2xrKTsK PiArCWVsc2UgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEpCj4gKwkJY2RjbGtfc3RhdGUu dm9sdGFnZV9sZXZlbCA9Cj4gKwkJCWljbF9jYWxjX3ZvbHRhZ2VfbGV2ZWwoY2RjbGtfc3RhdGUu Y2RjbGspOwo+ICsJZWxzZSBpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMCkKPiArCQljZGNs a19zdGF0ZS52b2x0YWdlX2xldmVsID0KPiArCQkJY25sX2NhbGNfdm9sdGFnZV9sZXZlbChjZGNs a19zdGF0ZS5jZGNsayk7Cj4gKwllbHNlCj4gKwkJY2RjbGtfc3RhdGUudm9sdGFnZV9sZXZlbCA9 Cj4gKwkJCWJ4dF9jYWxjX3ZvbHRhZ2VfbGV2ZWwoY2RjbGtfc3RhdGUuY2RjbGspOwo+ICAKPiAg CWJ4dF9zZXRfY2RjbGsoZGV2X3ByaXYsICZjZGNsa19zdGF0ZSwgSU5WQUxJRF9QSVBFKTsKPiAg fQo+IEBAIC0xNzM4LDIyICsxNzQ5LDYgQEAgc3RhdGljIHZvaWQgaWNsX2luaXRfY2RjbGsoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJYnh0X3NldF9jZGNsayhkZXZfcHJp diwgJnNhbml0aXplZF9zdGF0ZSwgSU5WQUxJRF9QSVBFKTsKPiAgfQo+ICAKPiAtc3RhdGljIHZv aWQgaWNsX3VuaW5pdF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g LXsKPiAtCXN0cnVjdCBpbnRlbF9jZGNsa19zdGF0ZSBjZGNsa19zdGF0ZSA9IGRldl9wcml2LT5j ZGNsay5odzsKPiAtCj4gLQljZGNsa19zdGF0ZS5jZGNsayA9IGNkY2xrX3N0YXRlLmJ5cGFzczsK PiAtCWNkY2xrX3N0YXRlLnZjbyA9IDA7Cj4gLQlpZiAoSVNfRUxLSEFSVExBS0UoZGV2X3ByaXYp KQo+IC0JCWNkY2xrX3N0YXRlLnZvbHRhZ2VfbGV2ZWwgPQo+IC0JCQllaGxfY2FsY192b2x0YWdl X2xldmVsKGNkY2xrX3N0YXRlLmNkY2xrKTsKPiAtCWVsc2UKPiAtCQljZGNsa19zdGF0ZS52b2x0 YWdlX2xldmVsID0KPiAtCQkJaWNsX2NhbGNfdm9sdGFnZV9sZXZlbChjZGNsa19zdGF0ZS5jZGNs ayk7Cj4gLQo+IC0JYnh0X3NldF9jZGNsayhkZXZfcHJpdiwgJmNkY2xrX3N0YXRlLCBJTlZBTElE X1BJUEUpOwo+IC19Cj4gLQo+ICBzdGF0aWMgdm9pZCBjbmxfaW5pdF9jZGNsayhzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHsKPiAgCXN0cnVjdCBpbnRlbF9jZGNsa19zdGF0 ZSBjZGNsa19zdGF0ZTsKPiBAQCAtMTc3MywxNyArMTc2OCw2IEBAIHN0YXRpYyB2b2lkIGNubF9p bml0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCWJ4dF9zZXRf Y2RjbGsoZGV2X3ByaXYsICZjZGNsa19zdGF0ZSwgSU5WQUxJRF9QSVBFKTsKPiAgfQo+ICAKPiAt c3RhdGljIHZvaWQgY25sX3VuaW5pdF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYpCj4gLXsKPiAtCXN0cnVjdCBpbnRlbF9jZGNsa19zdGF0ZSBjZGNsa19zdGF0ZSA9IGRl dl9wcml2LT5jZGNsay5odzsKPiAtCj4gLQljZGNsa19zdGF0ZS5jZGNsayA9IGNkY2xrX3N0YXRl LmJ5cGFzczsKPiAtCWNkY2xrX3N0YXRlLnZjbyA9IDA7Cj4gLQljZGNsa19zdGF0ZS52b2x0YWdl X2xldmVsID0gY25sX2NhbGNfdm9sdGFnZV9sZXZlbChjZGNsa19zdGF0ZS5jZGNsayk7Cj4gLQo+ IC0JYnh0X3NldF9jZGNsayhkZXZfcHJpdiwgJmNkY2xrX3N0YXRlLCBJTlZBTElEX1BJUEUpOwo+ IC19Cj4gLQo+ICAvKioKPiAgICogaW50ZWxfY2RjbGtfaW5pdCAtIEluaXRpYWxpemUgQ0RDTEsK PiAgICogQGk5MTU6IGk5MTUgZGV2aWNlCj4gQEAgLTE4MTQsMTQgKzE3OTgsMTAgQEAgdm9pZCBp bnRlbF9jZGNsa19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ICAgKi8KPiAg dm9pZCBpbnRlbF9jZGNsa191bmluaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4g IHsKPiAtCWlmIChJTlRFTF9HRU4oaTkxNSkgPj0gMTEpCj4gLQkJaWNsX3VuaW5pdF9jZGNsayhp OTE1KTsKPiAtCWVsc2UgaWYgKElTX0NBTk5PTkxBS0UoaTkxNSkpCj4gLQkJY25sX3VuaW5pdF9j ZGNsayhpOTE1KTsKPiArCWlmIChJU19HRU45X0xQKGk5MTUpIHx8IElOVEVMX0dFTihpOTE1KSA+ PSAxMCkKCkkgdGhpbmsgdGhlIGdlbmVyYWwgY29uY2Vuc3VzIGhhcyBiZWVuIHRvIGxpc3QgcGxh dGZvcm1zCmZyb20gbmV3IHRvIG9sZC4gTWlnaHQgYmUgZ29vZCB0byBzdGljayB0byB0aGF0IGV2 ZW4Kd2l0aGluIGNvbmRpdGlvbnMgbGlrZSB0aGlzLiBUaGVyZSBtYXkgaGF2ZSBiZWVuIG90aGVy IGNhc2VzIGxpa2UgdGhpcwppbiB0aGVzZSBwYXRjaGVzIHRoYXQgSSBkaWRuJ3Qgc3BvdC4KClJl dmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t PgoKPiArCQlieHRfdW5pbml0X2NkY2xrKGk5MTUpOwo+ICAJZWxzZSBpZiAoSVNfR0VOOV9CQyhp OTE1KSkKPiAgCQlza2xfdW5pbml0X2NkY2xrKGk5MTUpOwo+IC0JZWxzZSBpZiAoSVNfR0VOOV9M UChpOTE1KSkKPiAtCQlieHRfdW5pbml0X2NkY2xrKGk5MTUpOwo+ICB9Cj4gIAo+ICAvKioKPiAt LSAKPiAyLjIwLjEKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4