From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 8/8] drm/i915: Consolidate {bxt, cnl, icl}_init_cdclk Date: Tue, 10 Sep 2019 15:44:29 +0300 Message-ID: <20190910124429.GN7482@intel.com> References: <20190907002143.22591-1-matthew.d.roper@intel.com> <20190907002143.22591-9-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD96D6E051 for ; Tue, 10 Sep 2019 12:44:32 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190907002143.22591-9-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBTZXAgMDYsIDIwMTkgYXQgMDU6MjE6NDNQTSAtMDcwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBUaGUgQlhUIGFuZCBDTkwgZnVuY3Rpb25zIHdlcmUgYWxyZWFkeSBiYXNpY2FsbHkgaWRl bnRpY2FsLCB3aGVyZWFzCj4gSUNMJ3MgZnVuY3Rpb24gdHJpZWQgdG8gZG8gaXRzIG93biBzYW5p dGl6YXRpb24gcmF0aGVyIHRoYW4gY2FsbGluZwo+IGJ4dF9zYW5pdGl6ZV9jZGNsay4KPiAKPiBU aGlzIHNob3VsZCBhY3R1YWxseSBmaXggYSBidWcgaW4gb3VyIElDTCBpbml0aWFsaXphdGlvbiB3 aGVyZSBpdCB3b3VsZAo+IGNvbnNpZGVyIHRoZSAvMiBDRDJYIGRpdmlkZXIgaW52YWxpZCBhbmQg Zm9yY2UgYW4gdW5uZWNlc3NhcnkKPiBzYW5pdGl6YXRpb24gKHdlIG5vdyBoYXZlIHZhbGlkIGNs b2NrIGZyZXF1ZW5jaWVzIHRoYXQgdXNlIHRoaXMKPiBkaXZpZGVyKS4KPiAKPiBDYzogVmlsbGUg U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5 OiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IFZp bGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2NkY2xrLmMgfCA2NSArLS0tLS0tLS0t LS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDYzIGRlbGV0 aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2lu dGVsX2NkY2xrLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2NkY2xrLmMK PiBpbmRleCAzNTY0OTU1OTFjZjkuLjBhZDgzZDY3OTMyZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2NkY2xrLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9kaXNwbGF5L2ludGVsX2NkY2xrLmMKPiBAQCAtMTcxOSw2MyArMTcxOSw2IEBAIHN0 YXRpYyB2b2lkIGJ4dF91bmluaXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KQo+ICAJYnh0X3NldF9jZGNsayhkZXZfcHJpdiwgJmNkY2xrX3N0YXRlLCBJTlZBTElEX1BJ UEUpOwo+ICB9Cj4gIAo+IC1zdGF0aWMgdm9pZCBpY2xfaW5pdF9jZGNsayhzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gLXsKPiAtCXN0cnVjdCBpbnRlbF9jZGNsa19zdGF0ZSBz YW5pdGl6ZWRfc3RhdGU7Cj4gLQl1MzIgdmFsOwo+IC0KPiAtCS8qIFRoaXMgc2V0cyBkZXZfcHJp di0+Y2RjbGsuaHcuICovCj4gLQlpbnRlbF91cGRhdGVfY2RjbGsoZGV2X3ByaXYpOwo+IC0JaW50 ZWxfZHVtcF9jZGNsa19zdGF0ZSgmZGV2X3ByaXYtPmNkY2xrLmh3LCAiQ3VycmVudCBDRENMSyIp Owo+IC0KPiAtCS8qIFRoaXMgbWVhbnMgQ0RDTEsgZGlzYWJsZWQuICovCj4gLQlpZiAoZGV2X3By aXYtPmNkY2xrLmh3LmNkY2xrID09IGRldl9wcml2LT5jZGNsay5ody5ieXBhc3MpCj4gLQkJZ290 byBzYW5pdGl6ZTsKPiAtCj4gLQl2YWwgPSBJOTE1X1JFQUQoQ0RDTEtfQ1RMKTsKPiAtCj4gLQlp ZiAoKHZhbCAmIEJYVF9DRENMS19DRDJYX0RJVl9TRUxfTUFTSykgIT0gMCkKPiAtCQlnb3RvIHNh bml0aXplOwo+IC0KPiAtCWlmICgodmFsICYgQ0RDTEtfRlJFUV9ERUNJTUFMX01BU0spICE9Cj4g LQkgICAgc2tsX2NkY2xrX2RlY2ltYWwoZGV2X3ByaXYtPmNkY2xrLmh3LmNkY2xrKSkKPiAtCQln b3RvIHNhbml0aXplOwo+IC0KPiAtCXJldHVybjsKPiAtCj4gLXNhbml0aXplOgo+IC0JRFJNX0RF QlVHX0tNUygiU2FuaXRpemluZyBjZGNsayBwcm9ncmFtbWVkIGJ5IHByZS1vc1xuIik7Cj4gLQo+ IC0Jc2FuaXRpemVkX3N0YXRlLnJlZiA9IGRldl9wcml2LT5jZGNsay5ody5yZWY7Cj4gLQlzYW5p dGl6ZWRfc3RhdGUuY2RjbGsgPSBjYWxjX2NkY2xrKGRldl9wcml2LCAwKTsKPiAtCXNhbml0aXpl ZF9zdGF0ZS52Y28gPSBjYWxjX2NkY2xrX3BsbF92Y28oZGV2X3ByaXYsCj4gLQkJCQkJCSBzYW5p dGl6ZWRfc3RhdGUuY2RjbGspOwo+IC0Jc2FuaXRpemVkX3N0YXRlLnZvbHRhZ2VfbGV2ZWwgPQo+ IC0JCWRldl9wcml2LT5kaXNwbGF5LmNhbGNfdm9sdGFnZV9sZXZlbChzYW5pdGl6ZWRfc3RhdGUu Y2RjbGspOwo+IC0KPiAtCWJ4dF9zZXRfY2RjbGsoZGV2X3ByaXYsICZzYW5pdGl6ZWRfc3RhdGUs IElOVkFMSURfUElQRSk7Cj4gLX0KPiAtCj4gLXN0YXRpYyB2b2lkIGNubF9pbml0X2NkY2xrKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAtewo+IC0Jc3RydWN0IGludGVsX2Nk Y2xrX3N0YXRlIGNkY2xrX3N0YXRlOwo+IC0KPiAtCWJ4dF9zYW5pdGl6ZV9jZGNsayhkZXZfcHJp dik7Cj4gLQo+IC0JaWYgKGRldl9wcml2LT5jZGNsay5ody5jZGNsayAhPSAwICYmCj4gLQkgICAg ZGV2X3ByaXYtPmNkY2xrLmh3LnZjbyAhPSAwKQo+IC0JCXJldHVybjsKPiAtCj4gLQljZGNsa19z dGF0ZSA9IGRldl9wcml2LT5jZGNsay5odzsKPiAtCj4gLQljZGNsa19zdGF0ZS5jZGNsayA9IGNh bGNfY2RjbGsoZGV2X3ByaXYsIDApOwo+IC0JY2RjbGtfc3RhdGUudmNvID0gY2FsY19jZGNsa19w bGxfdmNvKGRldl9wcml2LCBjZGNsa19zdGF0ZS5jZGNsayk7Cj4gLQljZGNsa19zdGF0ZS52b2x0 YWdlX2xldmVsID0KPiAtCQlkZXZfcHJpdi0+ZGlzcGxheS5jYWxjX3ZvbHRhZ2VfbGV2ZWwoY2Rj bGtfc3RhdGUuY2RjbGspOwo+IC0KPiAtCWJ4dF9zZXRfY2RjbGsoZGV2X3ByaXYsICZjZGNsa19z dGF0ZSwgSU5WQUxJRF9QSVBFKTsKPiAtfQo+IC0KPiAgLyoqCj4gICAqIGludGVsX2NkY2xrX2lu aXQgLSBJbml0aWFsaXplIENEQ0xLCj4gICAqIEBpOTE1OiBpOTE1IGRldmljZQo+IEBAIC0xNzg3 LDE0ICsxNzMwLDEwIEBAIHN0YXRpYyB2b2lkIGNubF9pbml0X2NkY2xrKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdikKPiAgICovCj4gIHZvaWQgaW50ZWxfY2RjbGtfaW5pdChzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSkKPiAgewo+IC0JaWYgKElOVEVMX0dFTihpOTE1KSA+ PSAxMSkKPiAtCQlpY2xfaW5pdF9jZGNsayhpOTE1KTsKPiAtCWVsc2UgaWYgKElTX0NBTk5PTkxB S0UoaTkxNSkpCj4gLQkJY25sX2luaXRfY2RjbGsoaTkxNSk7Cj4gKwlpZiAoSVNfR0VOOV9MUChp OTE1KSB8fCBJTlRFTF9HRU4oaTkxNSkgPj0gMTApCj4gKwkJYnh0X2luaXRfY2RjbGsoaTkxNSk7 Cj4gIAllbHNlIGlmIChJU19HRU45X0JDKGk5MTUpKQo+ICAJCXNrbF9pbml0X2NkY2xrKGk5MTUp Owo+IC0JZWxzZSBpZiAoSVNfR0VOOV9MUChpOTE1KSkKPiAtCQlieHRfaW5pdF9jZGNsayhpOTE1 KTsKPiAgfQo+ICAKPiAgLyoqCj4gLS0gCj4gMi4yMC4xCgotLSAKVmlsbGUgU3lyasOkbMOkCklu dGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==