All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/nfs-utils: enable IPv6 if libtirpc is selected
Date: Tue, 10 Sep 2019 12:55:48 +0200	[thread overview]
Message-ID: <20190910125548.64acb272@windsurf> (raw)
In-Reply-To: <CAJ4jsaefMaEjAuJiqjtkNSNtGQJ=g4UP9xVg786+PE93JpHzkw@mail.gmail.com>

On Tue, 10 Sep 2019 07:29:39 -0300
Carlos Santos <unixmania@gmail.com> wrote:

> > >  ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
> > > -NFS_UTILS_CONF_OPTS += --enable-tirpc
> > > +NFS_UTILS_CONF_OPTS += --enable-tirpc --enable-ipv6
> > >  NFS_UTILS_DEPENDENCIES += libtirpc
> > >  else
> > > -NFS_UTILS_CONF_OPTS += --disable-tirpc
> > > +NFS_UTILS_CONF_OPTS += --disable-tirpc --disable-ipv6
> > >  endif
> > >
> > >  define NFS_UTILS_INSTALL_FIXUP
> > >  
> 
> 2019-09-10T07:22:05 configure: error: '--enable-ipv6' requires TIRPC support.

How come this happens ? We only pass --enable-ipv6 when TIRPC is
available.

> Quite frankly this is a foolish discussion since nfs-utils selects
> rpcbind which in its turn selects libtirpc. Anyway, your project, your
> rules...

Ah, but I didn't realize that and you never mentioned it so far I
believe. Indeed, it even makes the current libtirpc condition in
nfs-utils.mk completely useless.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-09-10 10:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12 17:37 [Buildroot] [PATCH v2] package/nfs-utils: enable IPv6 unixmania at gmail.com
2019-09-09  8:03 ` Thomas Petazzoni
2019-09-09  9:16   ` Arnout Vandecappelle
2019-09-09 23:56     ` [Buildroot] [PATCH v2] package/nfs-utils: enable IPv6 if libtirpc is selected unixmania at gmail.com
2019-09-10  7:06       ` Arnout Vandecappelle
2019-09-10 10:29         ` Carlos Santos
2019-09-10 10:55           ` Thomas Petazzoni [this message]
2019-09-10 11:03             ` Carlos Santos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190910125548.64acb272@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.