From: Kalle Valo <kvalo@codeaurora.org>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org, Ben Greear <greearb@candelatech.com>
Subject: Re: [PATCH] ath10k: Free beacon buf later in vdev teardown.
Date: Tue, 10 Sep 2019 13:12:44 +0000 (UTC) [thread overview]
Message-ID: <20190910131244.1343F6050D@smtp.codeaurora.org> (raw)
In-Reply-To: <20190227162756.13048-1-greearb@candelatech.com>
greearb@candelatech.com wrote:
> My wave-1 firmware often crashes when I am bringing down
> AP vdevs, and sometimes at least some machines lockup hard
> after spewing IOMMU errors.
>
> I don't see the same issue in STA mode, so I suspect beacons
> are the issue.
>
> Moving the beacon buf deletion to later in the vdev teardown
> logic appears to help this problem. Firmware still crashes
> often, but several iterations did not show IOMMU errors and
> machine didn't hang.
I'm not really fond of fixing issues just by luck but after a quick look at the
code I can't see any harm in this change either. So I guess it's ok.
But can you provide the exact hardware and firmware you used for testing, I'll
add it to the commit log. I want to document that in every commit:
https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#guidelines
Please also CC ath10k list when submitting patches.
--
https://patchwork.kernel.org/patch/10831867/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-09-10 13:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 16:27 [PATCH] ath10k: Free beacon buf later in vdev teardown greearb
2019-09-10 13:12 ` Kalle Valo [this message]
[not found] ` <20190910131244.267AF602F2@smtp.codeaurora.org>
2019-09-10 13:19 ` Ben Greear
2019-09-12 12:47 ` Kalle Valo
2019-09-12 14:52 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190910131244.1343F6050D@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.