From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:adf:ef42:0:0:0:0:0 with SMTP id c2csp5461387wrp; Tue, 10 Sep 2019 06:16:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqyOxKc8AH10YQKGWqHiLiZHGplQxzSxKxcukuXQnwboTrMcDLamjXy6B8FtIs1oOL83dEjy X-Received: by 2002:a17:906:94c5:: with SMTP id d5mr24142486ejy.180.1568121403763; Tue, 10 Sep 2019 06:16:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568121403; cv=none; d=google.com; s=arc-20160816; b=CnpEZQyy6oVZyMaEJlaMXOOfEIUK6vTt55f43VfIrxLzD0i9T16/vm4dvY2x7iyPTs H1LJbG+NrgzfVAzLFpIw7vmheq3C6i7p+mNTRMBeSYva0TwePJeVkJpXwcGmGZ4mym8o CKavNzL7eZ89d7AiiSgoLUEjrU5Oq/6JW9f62r0PUSb8dEwsv5h/KiWtoyfQ1U01K7KM 9oU3lCVPo8gv3qDeoht+ytnaPg8vob0+C3qhhx2Y+OeSqbTJVsuNPjLh5tfll8Z0UW/R lFm/XmjlEio/RLP2bfTahSetntxCb1qTCtNiIiOLu7Po2evZDIWOnbV8EkniAyV6dK9G GVqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:to:from:date; bh=TIw4qhgUk2ngQ89KDSuwBgIQ6T4m31nRBK+lITk/0/w=; b=QFsybq6uz7d7AmoBJ1wNPvaB76ANzN+M+TXp+U2880SdKPyFkVCY/x/TxcT8cJKziQ d/OvtP55ky2+Nb4rZ0KsHZo8rC1GC/jQvt/5X49QRa2uxjenYY7atptrm5ZoevzyfXx9 TeJICT8ZzlLvwh8nAyPl7tAHvpdj1F4+C8xsr/sI/d7brbvdbUzi+4IhACEZy9nW2nrI ft8KWSFdtH0bnLUy2Z5QP9HsFx2pyIN5bnLdVrjBSMCzt/IShQQnT5aZKpnaq333CQij bE8a0IGysNEppdsPJ3cex3/8pW4xV1wpzBFYmFjuvhwQXB3iiLlgOIJClKP9OhPst/wU 75+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p40si10810541eda.334.2019.09.10.06.16.43 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Sep 2019 06:16:43 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:39742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7g0f-0008NZ-WC for alex.bennee@linaro.org; Tue, 10 Sep 2019 09:16:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37643) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7g0S-0008Md-C7 for qemu-arm@nongnu.org; Tue, 10 Sep 2019 09:16:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i7g0R-0006ZC-5E for qemu-arm@nongnu.org; Tue, 10 Sep 2019 09:16:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43256) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i7g0Q-0006Xt-U0; Tue, 10 Sep 2019 09:16:27 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4EAFD20F8; Tue, 10 Sep 2019 13:16:24 +0000 (UTC) Received: from work-vm (ovpn-117-238.ams2.redhat.com [10.36.117.238]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 36E5C5D6B2; Tue, 10 Sep 2019 13:16:20 +0000 (UTC) Date: Tue, 10 Sep 2019 14:16:17 +0100 From: "Dr. David Alan Gilbert" To: Beata Michalska Message-ID: <20190910131617.GC2797@work-vm> References: <20190910095610.4546-1-beata.michalska@linaro.org> <20190910095610.4546-4-beata.michalska@linaro.org> <20190910102601.GA2797@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.71]); Tue, 10 Sep 2019 13:16:24 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-arm] [PATCH 3/4] migration: ram: Switch to ram block writeback X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , quintela@redhat.com, Richard Henderson , qemu-devel@nongnu.org, shameerali.kolothum.thodi@huawei.com, eric.auger@redhat.com, qemu-arm@nongnu.org, pbonzini@redhat.com Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: hABo0jcOjcaC * Beata Michalska (beata.michalska@linaro.org) wrote: > On Tue, 10 Sep 2019 at 12:26, Dr. David Alan Gilbert > wrote: > > > > * Beata Michalska (beata.michalska@linaro.org) wrote: > > > Switch to ram block writeback for pmem migration. > > > > > > Signed-off-by: Beata Michalska > > > --- > > > migration/ram.c | 5 +---- > > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > > > diff --git a/migration/ram.c b/migration/ram.c > > > index b01a37e7ca..8ea0bd63fc 100644 > > > --- a/migration/ram.c > > > +++ b/migration/ram.c > > > @@ -33,7 +33,6 @@ > > > #include "qemu/bitops.h" > > > #include "qemu/bitmap.h" > > > #include "qemu/main-loop.h" > > > -#include "qemu/pmem.h" > > > #include "xbzrle.h" > > > #include "ram.h" > > > #include "migration.h" > > > @@ -4064,9 +4063,7 @@ static int ram_load_cleanup(void *opaque) > > > RAMBlock *rb; > > > > > > RAMBLOCK_FOREACH_NOT_IGNORED(rb) { > > > - if (ramblock_is_pmem(rb)) { > > > - pmem_persist(rb->host, rb->used_length); > > > - } > > > + qemu_ram_block_writeback(rb); > > > > ACK for migration > > > > Although I do worry that if you really have pmem hardware, is it better > > to fail the migration if you don't have libpmem available? > > According to the PMDG man page, pmem_persist is supposed to be > equivalent for the msync. OK, but you do define qemu_ram_block_writeback to fall back to fdatasync; so that would be too little? > It's just more performant. So in case of real pmem hardware it should > be all good. > > [http://pmem.io/pmdk/manpages/linux/v1.2/libpmem.3.html] Dave > > BR > Beata > > > > Dave > > > > > } > > > > > > xbzrle_load_cleanup(); > > > -- > > > 2.17.1 > > > > > -- > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E080C3A5A2 for ; Tue, 10 Sep 2019 13:19:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25C492084D for ; Tue, 10 Sep 2019 13:19:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25C492084D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7g30-0001Uw-49 for qemu-devel@archiver.kernel.org; Tue, 10 Sep 2019 09:19:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37677) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7g0V-0008Nd-7W for qemu-devel@nongnu.org; Tue, 10 Sep 2019 09:16:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i7g0T-0006aL-Rg for qemu-devel@nongnu.org; Tue, 10 Sep 2019 09:16:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43256) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i7g0Q-0006Xt-U0; Tue, 10 Sep 2019 09:16:27 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4EAFD20F8; Tue, 10 Sep 2019 13:16:24 +0000 (UTC) Received: from work-vm (ovpn-117-238.ams2.redhat.com [10.36.117.238]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 36E5C5D6B2; Tue, 10 Sep 2019 13:16:20 +0000 (UTC) Date: Tue, 10 Sep 2019 14:16:17 +0100 From: "Dr. David Alan Gilbert" To: Beata Michalska Message-ID: <20190910131617.GC2797@work-vm> References: <20190910095610.4546-1-beata.michalska@linaro.org> <20190910095610.4546-4-beata.michalska@linaro.org> <20190910102601.GA2797@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.71]); Tue, 10 Sep 2019 13:16:24 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 3/4] migration: ram: Switch to ram block writeback X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , quintela@redhat.com, Richard Henderson , qemu-devel@nongnu.org, shameerali.kolothum.thodi@huawei.com, eric.auger@redhat.com, qemu-arm@nongnu.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Beata Michalska (beata.michalska@linaro.org) wrote: > On Tue, 10 Sep 2019 at 12:26, Dr. David Alan Gilbert > wrote: > > > > * Beata Michalska (beata.michalska@linaro.org) wrote: > > > Switch to ram block writeback for pmem migration. > > > > > > Signed-off-by: Beata Michalska > > > --- > > > migration/ram.c | 5 +---- > > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > > > diff --git a/migration/ram.c b/migration/ram.c > > > index b01a37e7ca..8ea0bd63fc 100644 > > > --- a/migration/ram.c > > > +++ b/migration/ram.c > > > @@ -33,7 +33,6 @@ > > > #include "qemu/bitops.h" > > > #include "qemu/bitmap.h" > > > #include "qemu/main-loop.h" > > > -#include "qemu/pmem.h" > > > #include "xbzrle.h" > > > #include "ram.h" > > > #include "migration.h" > > > @@ -4064,9 +4063,7 @@ static int ram_load_cleanup(void *opaque) > > > RAMBlock *rb; > > > > > > RAMBLOCK_FOREACH_NOT_IGNORED(rb) { > > > - if (ramblock_is_pmem(rb)) { > > > - pmem_persist(rb->host, rb->used_length); > > > - } > > > + qemu_ram_block_writeback(rb); > > > > ACK for migration > > > > Although I do worry that if you really have pmem hardware, is it better > > to fail the migration if you don't have libpmem available? > > According to the PMDG man page, pmem_persist is supposed to be > equivalent for the msync. OK, but you do define qemu_ram_block_writeback to fall back to fdatasync; so that would be too little? > It's just more performant. So in case of real pmem hardware it should > be all good. > > [http://pmem.io/pmdk/manpages/linux/v1.2/libpmem.3.html] Dave > > BR > Beata > > > > Dave > > > > > } > > > > > > xbzrle_load_cleanup(); > > > -- > > > 2.17.1 > > > > > -- > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK