From: Andrew Lunn <andrew@lunn.ch>
To: George McCollister <george.mccollister@gmail.com>
Cc: netdev@vger.kernel.org, Woojung Huh <woojung.huh@microchip.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Tristram Ha <Tristram.Ha@microchip.com>,
"David S. Miller" <davem@davemloft.net>,
Marek Vasut <marex@denx.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/3] net: dsa: microchip: add KSZ9477 I2C driver
Date: Tue, 10 Sep 2019 16:03:04 +0200 [thread overview]
Message-ID: <20190910140304.GA4683@lunn.ch> (raw)
In-Reply-To: <20190910131836.114058-2-george.mccollister@gmail.com>
Hi George
> +KSZ_REGMAP_TABLE(ksz9477, not_used, 16, 0, 0);
> +
> @@ -294,6 +294,8 @@ static inline void ksz_pwrite32(struct ksz_device *dev, int port, int offset,
> #define KSZ_SPI_OP_RD 3
> #define KSZ_SPI_OP_WR 2
>
> +#define swabnot_used(x) 0
> +
> #define KSZ_SPI_OP_FLAG_MASK(opcode, swp, regbits, regpad) \
> swab##swp((opcode) << ((regbits) + (regpad)))
There seems to be quite a lot of macro magic here which is not
obvious. Can this be simplified or made more obvious?
Andrew
next prev parent reply other threads:[~2019-09-10 14:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 13:18 [PATCH net-next v2 0/3] add ksz9567 with I2C support to ksz9477 driver George McCollister
2019-09-10 13:18 ` [PATCH net-next v2 1/3] net: dsa: microchip: add KSZ9477 I2C driver George McCollister
2019-09-10 14:03 ` Andrew Lunn [this message]
2019-09-10 14:40 ` George McCollister
2019-09-10 13:18 ` [PATCH net-next v2 2/3] net: dsa: microchip: add ksz9567 to ksz9477 driver George McCollister
2019-09-10 18:30 ` Andrew Lunn
2019-09-10 18:35 ` Florian Fainelli
2019-09-10 13:18 ` [PATCH net-next v2 3/3] net: dsa: microchip: remove NET_DSA_TAG_KSZ_COMMON George McCollister
2019-09-10 18:35 ` Florian Fainelli
2019-09-10 18:37 ` Andrew Lunn
2019-09-12 10:39 ` [PATCH net-next v2 0/3] add ksz9567 with I2C support to ksz9477 driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190910140304.GA4683@lunn.ch \
--to=andrew@lunn.ch \
--cc=Tristram.Ha@microchip.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=george.mccollister@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.