From: Antoine Tenart <antoine.tenart@bootlin.com>
To: Pascal van Leeuwen <pascalvanl@gmail.com>
Cc: linux-crypto@vger.kernel.org, antoine.tenart@bootlin.com,
herbert@gondor.apana.org.au, davem@davemloft.net,
Pascal van Leeuwen <pvanleeuwen@verimatrix.com>
Subject: Re: [PATCH 1/2] crypto: inside-secure - Added support for the CHACHA20 skcipher
Date: Tue, 10 Sep 2019 18:32:46 +0100 [thread overview]
Message-ID: <20190910173246.GA14055@kwain> (raw)
In-Reply-To: <1568126293-4039-2-git-send-email-pvanleeuwen@verimatrix.com>
Hi Pascal,
On Tue, Sep 10, 2019 at 04:38:12PM +0200, Pascal van Leeuwen wrote:
>
> @@ -112,7 +123,7 @@ static void safexcel_cipher_token(struct safexcel_cipher_ctx *ctx, u8 *iv,
> block_sz = DES3_EDE_BLOCK_SIZE;
> cdesc->control_data.options |= EIP197_OPTION_2_TOKEN_IV_CMD;
> break;
> - case SAFEXCEL_AES:
> + default: /* case SAFEXCEL_AES */
Can't you keep an explicit case here?
> block_sz = AES_BLOCK_SIZE;
> cdesc->control_data.options |= EIP197_OPTION_4_TOKEN_IV_CMD;
> break;
Thanks,
Antoine
--
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-09-10 17:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 14:38 [PATCH 0/2] crypto: inside-secure: Add support for the Chacha20 skcipher and the Chacha20-Poly1305 AEAD suites Pascal van Leeuwen
2019-09-10 14:38 ` [PATCH 1/2] crypto: inside-secure - Added support for the CHACHA20 skcipher Pascal van Leeuwen
2019-09-10 17:32 ` Antoine Tenart [this message]
2019-09-10 18:58 ` Pascal Van Leeuwen
2019-09-11 15:21 ` Antoine Tenart
2019-09-11 15:32 ` Pascal Van Leeuwen
2019-09-10 14:38 ` [PATCH 2/2] crypto: inside-secure - Add support for the Chacha20-Poly1305 AEAD Pascal van Leeuwen
2019-09-11 15:29 ` Antoine Tenart
2019-09-11 15:37 ` Pascal Van Leeuwen
2019-09-11 15:45 ` Antoine Tenart
2019-09-11 15:49 ` Pascal Van Leeuwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190910173246.GA14055@kwain \
--to=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=pascalvanl@gmail.com \
--cc=pvanleeuwen@verimatrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.