From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH] drm: include: fix W=1 warnings in struct drm_dsc_config Date: Tue, 10 Sep 2019 10:58:07 -0700 Message-ID: <20190910175806.GA31258@intel.com> References: <20190909135205.10277-1-benjamin.gaignard@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3CBF16E102 for ; Tue, 10 Sep 2019 17:56:41 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Harry Wentland Cc: Benjamin Gaignard , "airlied@linux.ie" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Gaurav K Singh List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBTZXAgMTAsIDIwMTkgYXQgMTI6NTg6MjRQTSArMDAwMCwgSGFycnkgV2VudGxhbmQg d3JvdGU6Cj4gK01hbmFzaSwgR2F1cmF2Cj4gCj4gT24gMjAxOS0wOS0wOSA5OjUyIGEubS4sIEJl bmphbWluIEdhaWduYXJkIHdyb3RlOgo+ID4gQ2hhbmdlIHNjYWxlX2luY3JlbWVudF9pbnRlcnZh bCBhbmQgbmZsX2JwZ19vZmZzZXQgZmllbGRzIHRvCj4gPiB1MzIgdG8gYXZvaWQgVz0xIHdhcm5p bmdzIGJlY2F1c2Ugd2UgYXJlIHRlc3RpbmcgdGhlbSBhZ2FpbnN0Cj4gPiA2NTUzNS4KPiA+IAo+ ID4gU2lnbmVkLW9mZi1ieTogQmVuamFtaW4gR2FpZ25hcmQgPGJlbmphbWluLmdhaWduYXJkQHN0 LmNvbT4KPiA+IC0tLQo+ID4gICBpbmNsdWRlL2RybS9kcm1fZHNjLmggfCA2ICsrKystLQo+ID4g ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4gCj4g PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX2RzYy5oIGIvaW5jbHVkZS9kcm0vZHJtX2Rz Yy5oCj4gPiBpbmRleCA4ODc5NTRjYmZjNjAuLmU0OTUwMjRlOTAxYyAxMDA2NDQKPiA+IC0tLSBh L2luY2x1ZGUvZHJtL2RybV9kc2MuaAo+ID4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2RzYy5oCj4g PiBAQCAtMjA3LDExICsyMDcsMTMgQEAgc3RydWN0IGRybV9kc2NfY29uZmlnIHsKPiA+ICAgCSAq IE51bWJlciBvZiBncm91cCB0aW1lcyBiZXR3ZWVuIGluY3JlbWVudGluZyB0aGUgc2NhbGUgZmFj dG9yIHZhbHVlCj4gPiAgIAkgKiB1c2VkIGF0IHRoZSBiZWdpbm5pbmcgb2YgYSBzbGljZS4KPiA+ ICAgCSAqLwo+ID4gLQl1MTYgc2NhbGVfaW5jcmVtZW50X2ludGVydmFsOwo+ID4gKwl1MzIgc2Nh bGVfaW5jcmVtZW50X2ludGVydmFsOwo+IAo+IFRoZSBEU0Mgc3BlYyBkZWZpbmVzIGJvdGggYXMg dTE2LiBJIHRoaW5rIHRoZSBjaGVjayBpbiBkcm1fZHNjLmMgaXMgCj4gdXNlbGVzcyBhbmQgc2hv dWxkIGJlIGRyb3BwZWQuCj4KCkkgYWdyZWUgd2l0aCBIYXJyeSBoZXJlLCBhbGwgdGhlc2UgdmFy aWFibGVzIHNob3VsZCBtYXRjaCB0aGUgbnVtYmVyIG9mIGJpdHMKaW4gdGhlIHNwZWMsIGluY3Jl YXNpbmcgdGhlbSB0byB1MzIgYWxsb3dzIG1vcmUgdmFsdWVzIHdoaWNoIHZpb2xhdGVzIHRoZQpE U0Mgc3BlYy4KCkl0IHNob3VsZCBzdGF5IHUxNgoKTWFuYXNpCiAKPiBIYXJyeQo+IAo+ID4gKwo+ ID4gICAJLyoqCj4gPiAgIAkgKiBAbmZsX2JwZ19vZmZzZXQ6IE5vbiBmaXJzdCBsaW5lIEJQRyBv ZmZzZXQgdG8gYmUgdXNlZAo+ID4gICAJICovCj4gPiAtCXUxNiBuZmxfYnBnX29mZnNldDsKPiA+ ICsKPiA+ICsJdTMyIG5mbF9icGdfb2Zmc2V0Owo+ID4gICAJLyoqCj4gPiAgIAkgKiBAc2xpY2Vf YnBnX29mZnNldDogQlBHIG9mZnNldCB1c2VkIHRvIGVuZm9yY2Ugc2xpY2UgYml0Cj4gPiAgIAkg Ki8KPiA+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C541C49ED7 for ; Tue, 10 Sep 2019 17:58:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79AAC21479 for ; Tue, 10 Sep 2019 17:58:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727198AbfIJR6D (ORCPT ); Tue, 10 Sep 2019 13:58:03 -0400 Received: from mga11.intel.com ([192.55.52.93]:49469 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbfIJR5u (ORCPT ); Tue, 10 Sep 2019 13:57:50 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Sep 2019 10:56:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,490,1559545200"; d="scan'208";a="191885982" Received: from labuser-z97x-ud5h.jf.intel.com (HELO intel.com) ([10.54.75.49]) by FMSMGA003.fm.intel.com with ESMTP; 10 Sep 2019 10:56:40 -0700 Date: Tue, 10 Sep 2019 10:58:07 -0700 From: Manasi Navare To: Harry Wentland Cc: Benjamin Gaignard , "benjamin.gaignard@linaro.org" , "airlied@linux.ie" , "daniel@ffwll.ch" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Gaurav K Singh Subject: Re: [PATCH] drm: include: fix W=1 warnings in struct drm_dsc_config Message-ID: <20190910175806.GA31258@intel.com> References: <20190909135205.10277-1-benjamin.gaignard@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 10, 2019 at 12:58:24PM +0000, Harry Wentland wrote: > +Manasi, Gaurav > > On 2019-09-09 9:52 a.m., Benjamin Gaignard wrote: > > Change scale_increment_interval and nfl_bpg_offset fields to > > u32 to avoid W=1 warnings because we are testing them against > > 65535. > > > > Signed-off-by: Benjamin Gaignard > > --- > > include/drm/drm_dsc.h | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/include/drm/drm_dsc.h b/include/drm/drm_dsc.h > > index 887954cbfc60..e495024e901c 100644 > > --- a/include/drm/drm_dsc.h > > +++ b/include/drm/drm_dsc.h > > @@ -207,11 +207,13 @@ struct drm_dsc_config { > > * Number of group times between incrementing the scale factor value > > * used at the beginning of a slice. > > */ > > - u16 scale_increment_interval; > > + u32 scale_increment_interval; > > The DSC spec defines both as u16. I think the check in drm_dsc.c is > useless and should be dropped. > I agree with Harry here, all these variables should match the number of bits in the spec, increasing them to u32 allows more values which violates the DSC spec. It should stay u16 Manasi > Harry > > > + > > /** > > * @nfl_bpg_offset: Non first line BPG offset to be used > > */ > > - u16 nfl_bpg_offset; > > + > > + u32 nfl_bpg_offset; > > /** > > * @slice_bpg_offset: BPG offset used to enforce slice bit > > */ > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel