From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sandro Volery <sandro@volery.com>
Cc: valdis.kletnieks@vt.edu, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: exfat: Avoid use of strcpy
Date: Wed, 11 Sep 2019 11:41:11 +0300 [thread overview]
Message-ID: <20190911084111.GG15977@kadam> (raw)
In-Reply-To: <20190911055749.GA10786@volery>
On Wed, Sep 11, 2019 at 07:57:49AM +0200, Sandro Volery wrote:
> Replaced strcpy with strscpy in exfat_core.c.
>
> Signed-off-by: Sandro Volery <sandro@volery.com>
> ---
> drivers/staging/exfat/exfat_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/exfat/exfat_core.c b/drivers/staging/exfat/exfat_core.c
> index da8c58149c35..c71b145e8a24 100644
> --- a/drivers/staging/exfat/exfat_core.c
> +++ b/drivers/staging/exfat/exfat_core.c
> @@ -2964,7 +2964,7 @@ s32 resolve_path(struct inode *inode, char *path, struct chain_t *p_dir,
> if (strlen(path) >= (MAX_NAME_LENGTH * MAX_CHARSET_SIZE))
> return FFS_INVALIDPATH;
>
> - strcpy(name_buf, path);
> + strscpy(name_buf, path, sizeof(name_buf));
It checked strlen() earlier so we know that it can't overflow but, oh
wow, the "name_buf" is a shared buffer. wow wow wow. This seems very
racy.
regards,
dan carpenter
next prev parent reply other threads:[~2019-09-11 8:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 5:57 [PATCH] Staging: exfat: Avoid use of strcpy Sandro Volery
2019-09-11 8:41 ` Dan Carpenter [this message]
2019-09-11 8:56 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190911084111.GG15977@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandro@volery.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.