From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/minimodem: new package
Date: Wed, 11 Sep 2019 15:52:18 +0200 [thread overview]
Message-ID: <20190911155218.35ff3c63@windsurf> (raw)
In-Reply-To: <20190909182345.1615-1-user@vserver64>
Hello Alexander,
On Mon, 9 Sep 2019 18:23:45 +0000
Alexander Kurz <akurz@blala.de> wrote:
> diff --git a/package/minimodem/Config.in b/package/minimodem/Config.in
> new file mode 100644
> index 0000000000..9d2afd6798
> --- /dev/null
> +++ b/package/minimodem/Config.in
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_MINIMODEM
> + select BR2_PACKAGE_FFTW_SINGLE
> + depends on BR2_PACKAGE_LIBSNDFILE || BR2_PACKAGE_ALSA_LIB_PCM || \
> + BR2_PACKAGE_PULSEAUDIO
I changed this to a select, as was initially suggested by Arnout.
> + bool "minimodem"
The bool statement should be before the select/depends on. This is just
a Buildroot rule, so that we do things consistently between packages. I
think it is reported by "make check-package".
> +MINIMODEM_DEPENDENCIES += fftw-single
A dependency on host-pkgconf was missing here.
I fixed those different issues, and applied. Thanks a lot for your
contribution!
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-09-11 13:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 18:23 [Buildroot] [PATCH v2] package/minimodem: new package Alexander Kurz
2019-09-11 13:52 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190911155218.35ff3c63@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.