From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rohit Sarkar <rohitsarkar5398@gmail.com>
Cc: devel@driverdev.osuosl.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org,
"Tobias Büttner" <tobias.buettner@fau.de>,
"Eric Anholt" <eric@anholt.net>,
"Stefan Wahren" <wahrenst@gmx.net>,
"Dominic Braun" <inf.braun@fau.de>,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH] staging: vhciq_core: replace snprintf with scnprintf
Date: Wed, 11 Sep 2019 17:24:22 +0000 [thread overview]
Message-ID: <20190911172422.GK20699@kadam> (raw)
In-Reply-To: <20190911150300.GA12027@SARKAR>
On Wed, Sep 11, 2019 at 08:33:00PM +0530, Rohit Sarkar wrote:
> There are a lot of usages of "snprintf" throughout the staging
> directory (315 to be exact)
> Would it be worthwhile to find ones that may cause an information leak
> and replace them with "scnprintf"?
A lot of times it's really easy to see that the uses are safe, so
snprintf() is fine in that case. If it's not obviously safe then change
it.
regards,
dan carpenter
next prev parent reply other threads:[~2019-09-11 17:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 13:51 [PATCH] staging: vhciq_core: replace snprintf with scnprintf Rohit Sarkar
2019-09-11 14:17 ` Stefan Wahren
2019-09-11 14:37 ` Rohit Sarkar
2019-09-11 14:46 ` Dan Carpenter
2019-09-11 15:15 ` Rohit Sarkar
2019-09-11 17:24 ` Dan Carpenter [this message]
2019-09-11 17:50 ` Rohit Sarkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190911172422.GK20699@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=gregkh@linuxfoundation.org \
--cc=inf.braun@fau.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rohitsarkar5398@gmail.com \
--cc=tobias.buettner@fau.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.