From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D1B4C5ACAE for ; Wed, 11 Sep 2019 19:02:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E27C0214DE for ; Wed, 11 Sep 2019 19:02:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730170AbfIKTBc (ORCPT ); Wed, 11 Sep 2019 15:01:32 -0400 Received: from mga02.intel.com ([134.134.136.20]:52456 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729016AbfIKTBc (ORCPT ); Wed, 11 Sep 2019 15:01:32 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2019 12:01:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,492,1559545200"; d="scan'208";a="268841530" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by orsmga001.jf.intel.com with ESMTP; 11 Sep 2019 12:01:32 -0700 Date: Wed, 11 Sep 2019 12:01:32 -0700 From: Sean Christopherson To: Bill Wendling Cc: kvm@vger.kernel.org Subject: Re: [kvm-unit-tests PATCH] x86: debug: use a constraint that doesn't allow a memory operand Message-ID: <20190911190131.GF1045@linux.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Sep 09, 2019 at 02:00:35PM -0700, Bill Wendling wrote: > The "lea" instruction cannot load the effective address into a memory > location. The "g" constraint allows a compiler to use a memory location. > A compiler that uses a register destination does so only because one is > available. Use a general register constraint to make sure it always uses > a register. > > Signed-off-by: Bill Wendling > --- Reviewed-by: Sean Christopherson