From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, pbonzini@redhat.com, ehabkost@redhat.com,
berrange@redhat.com, quintela@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/5] Automatic RCU read unlock
Date: Wed, 11 Sep 2019 20:06:17 +0100 [thread overview]
Message-ID: <20190911190622.7629-1-dgilbert@redhat.com> (raw)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
This patch uses glib's g_auto mechanism to automatically free
rcu_read_lock's at the end of the block. Given that humans
have a habit of forgetting an error path somewhere it's
best to leave it to the compiler.
(Note I've found the actual cause of my deadlock actually
isn't a misisng unlock; it's a lock ordering thing)
v2
Rework auto mechanism based on Dan and Eduardo's comments
Add some more uses in memory/exec
Add a missing unlock in a function I've not used the macro in
Dr. David Alan Gilbert (5):
rcu: Add automatically released rcu_read_lock variant
migration: Use automatic rcu_read unlock in ram.c
migration: Use automatic rcu_read unlock in rdma.c
rcu: Use automatic rc_read unlock in core memory/exec code
migration: Missing rcu_read_unlock
exec.c | 46 ++++++++++-----------------------
include/exec/ram_addr.h | 8 ++----
include/qemu/rcu.h | 18 +++++++++++++
memory.c | 15 ++++-------
migration/ram.c | 26 ++++++++-----------
migration/rdma.c | 57 ++++++++---------------------------------
6 files changed, 60 insertions(+), 110 deletions(-)
--
2.21.0
next reply other threads:[~2019-09-11 19:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 19:06 Dr. David Alan Gilbert (git) [this message]
2019-09-11 19:06 ` [Qemu-devel] [PATCH v2 1/5] rcu: Add automatically released rcu_read_lock variant Dr. David Alan Gilbert (git)
2019-09-12 9:35 ` Daniel P. Berrangé
2019-09-12 12:30 ` Paolo Bonzini
2019-09-12 17:45 ` Dr. David Alan Gilbert
2019-09-13 7:13 ` Paolo Bonzini
2019-09-13 10:24 ` Dr. David Alan Gilbert
2019-09-13 10:29 ` Paolo Bonzini
2019-09-11 19:06 ` [Qemu-devel] [PATCH v2 2/5] migration: Use automatic rcu_read unlock in ram.c Dr. David Alan Gilbert (git)
2019-09-12 9:37 ` Daniel P. Berrangé
2019-09-11 19:06 ` [Qemu-devel] [PATCH v2 3/5] migration: Use automatic rcu_read unlock in rdma.c Dr. David Alan Gilbert (git)
2019-09-12 9:37 ` Daniel P. Berrangé
2019-09-11 19:06 ` [Qemu-devel] [PATCH v2 4/5] rcu: Use automatic rc_read unlock in core memory/exec code Dr. David Alan Gilbert (git)
2019-09-12 9:38 ` Daniel P. Berrangé
2019-09-11 19:06 ` [Qemu-devel] [PATCH v2 5/5] migration: Missing rcu_read_unlock Dr. David Alan Gilbert (git)
2019-09-12 9:38 ` Daniel P. Berrangé
2019-09-12 12:32 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190911190622.7629-1-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.