From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, quintela@redhat.com, berrange@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qemu-file: Rework old qemu_fflush comment
Date: Thu, 12 Sep 2019 11:16:41 +0100 [thread overview]
Message-ID: <20190912101641.GD7230@work-vm> (raw)
In-Reply-To: <20190823103946.7388-1-dgilbert@redhat.com>
* Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Commit 11808bb removed the non-iovec based write support,
> the comment hung on.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Queued
> ---
> migration/qemu-file.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/migration/qemu-file.c b/migration/qemu-file.c
> index e33c46764f..075faf03c3 100644
> --- a/migration/qemu-file.c
> +++ b/migration/qemu-file.c
> @@ -201,9 +201,8 @@ static void qemu_iovec_release_ram(QEMUFile *f)
> /**
> * Flushes QEMUFile buffer
> *
> - * If there is writev_buffer QEMUFileOps it uses it otherwise uses
> - * put_buffer ops. This will flush all pending data. If data was
> - * only partially flushed, it will set an error state.
> + * This will flush all pending data. If data was only partially flushed, it
> + * will set an error state.
> */
> void qemu_fflush(QEMUFile *f)
> {
> --
> 2.21.0
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2019-09-12 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 10:39 [Qemu-devel] [PATCH] qemu-file: Rework old qemu_fflush comment Dr. David Alan Gilbert (git)
2019-08-23 10:46 ` Daniel P. Berrangé
2019-08-26 8:01 ` Stefano Garzarella
2019-09-11 11:20 ` Juan Quintela
2019-09-12 10:16 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190912101641.GD7230@work-vm \
--to=dgilbert@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.