From: Mike Rapoport <rppt@linux.ibm.com>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memblock: fix typo in memblock doc
Date: Thu, 12 Sep 2019 11:35:36 +0100 [thread overview]
Message-ID: <20190912103535.GB9062@linux.ibm.com> (raw)
In-Reply-To: <59f571f6-785c-7f6e-fd03-5cfc76da27be@cn.fujitsu.com>
On Thu, Sep 12, 2019 at 10:54:09AM +0800, Cao jin wrote:
> On 9/11/19 10:42 PM, Mike Rapoport wrote:
> > On Wed, Sep 11, 2019 at 11:08:56AM +0800, Cao jin wrote:
> >> elaboarte -> elaborate
> >> architecure -> architecture
> >> compltes -> completes
> >>
> >> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> >> ---
> >> mm/memblock.c | 6 +++---
> >> 1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/mm/memblock.c b/mm/memblock.c
> >> index 7d4f61ae666a..0d0f92003d18 100644
> >> --- a/mm/memblock.c
> >> +++ b/mm/memblock.c
> >> @@ -83,16 +83,16 @@
> >> * Note, that both API variants use implict assumptions about allowed
> >> * memory ranges and the fallback methods. Consult the documentation
> >> * of :c:func:`memblock_alloc_internal` and
> >> - * :c:func:`memblock_alloc_range_nid` functions for more elaboarte
> >> + * :c:func:`memblock_alloc_range_nid` functions for more elaborate
> >
> > While on it, could you please replace the
> > :c:func:`memblock_alloc_range_nid` construct with
> > memblock_alloc_range_nid()?
> >
> > And that would be really great to see all the :c:func:`foo` changed to
> > foo().
> >
>
> Sure. BTW, do you want convert all the markups too?
>
> :c:type:`foo` -> struct foo
> %FOO -> FOO
> ``foo`` -> foo
> **foo** -> foo
The documentation toolchain can recognize now foo() as a function and does
not require the :c:func: prefix for that. AFAIK it only works for
functions, so please don't change the rest of the markup.
> --
> Sincerely,
> Cao jin
>
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2019-09-12 10:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 3:08 [PATCH] mm/memblock: fix typo in memblock doc Cao jin
2019-09-11 14:42 ` Mike Rapoport
2019-09-12 2:54 ` Cao jin
2019-09-12 10:35 ` Mike Rapoport [this message]
2019-09-12 12:29 ` Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190912103535.GB9062@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.