From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Nathan Lynch <nathanl@linux.ibm.com>
Cc: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH v3 3/5] powerpc/numa: Use cpu node map of first sibling thread
Date: Thu, 12 Sep 2019 22:53:55 +0530 [thread overview]
Message-ID: <20190912171751.GA16497@linux.vnet.ibm.com> (raw)
In-Reply-To: <87ftl1qxey.fsf@linux.ibm.com>
>
> I think just WARN_ON(cpu_online(fcpu)) would be satisfactory. In my
> experience, the downstream effects of violating this condition are
> varied and quite difficult to debug. Seems only appropriate to emit a
> warning and stack trace before the OS inevitably becomes unstable.
I still have to try but wouldn't this be a problem for the boot-cpu?
I mean boot-cpu would be marked online while it tries to do numa_setup_cpu.
No?
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2019-09-12 17:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 13:50 [PATCH v3 0/5] Early node associativity Srikar Dronamraju
2019-09-06 13:50 ` [PATCH v3 1/5] powerpc/vphn: Check for error from hcall_vphn Srikar Dronamraju
2019-09-06 13:50 ` [PATCH v3 2/5] powerpc/numa: Handle extra hcall_vphn error cases Srikar Dronamraju
2019-09-06 13:50 ` [PATCH v3 3/5] powerpc/numa: Use cpu node map of first sibling thread Srikar Dronamraju
2019-09-11 14:48 ` Nathan Lynch
2019-09-11 17:05 ` Srikar Dronamraju
2019-09-12 16:41 ` Nathan Lynch
2019-09-12 17:23 ` Srikar Dronamraju [this message]
2019-09-12 18:15 ` Nathan Lynch
2019-09-13 5:44 ` Srikar Dronamraju
2019-09-06 13:50 ` [PATCH v3 4/5] powerpc/numa: Early request for home node associativity Srikar Dronamraju
2019-09-06 13:50 ` [PATCH v3 5/5] powerpc/numa: Remove late " Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190912171751.GA16497@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nathanl@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=sathnaga@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.