From: Guenter Roeck <linux@roeck-us.net>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: ABI for these two registers?
Date: Thu, 12 Sep 2019 15:09:47 -0700 [thread overview]
Message-ID: <20190912220947.GA8072@roeck-us.net> (raw)
In-Reply-To: <20190912210957.GA21945@Asurada-Nvidia.nvidia.com>
On Thu, Sep 12, 2019 at 02:09:58PM -0700, Nicolin Chen wrote:
> Hello Guenter,
>
> On Thu, Sep 12, 2019 at 11:32:18AM -0700, Guenter Roeck wrote:
> > On Wed, Sep 11, 2019 at 05:28:14PM -0700, Nicolin Chen wrote:
> > > Hello Guenter,
> > >
> > > Datasheet: http://www.ti.com/lit/ds/symlink/ina3221.pdf
> > > (At page 32, chapter 8.6.2.14 and 8.6.2.15)
> > >
> > > I have two registers that I need to expose to user space:
> > > Shunt-Voltage-Sum and Shunt-Voltage-Limit registers
> > >
> > > Right now in[123]_input of INA3221 are for voltage channels
> > > while in[456]_input are for Shunt voltage channels.
> > >
> > > So can I just use in7_input and in7_crit for them?
> > >
> > Doesn't Shunt-Voltage-Limit apply to in[456]_input ?
> > If so, the limit should be attached to those.
>
> The initial patch of ina3221 driver applied Shunt-Voltage-Limits,
> being named as "Critical Alert Limit Registers" in the datasheet,
> to curr[123]_crit, corresponding to curr[123] and in[456]_input.
>
> And this Shunt-Voltage-Limit-Sum is more related to the reading
> from Shunt-Voltage-Sum, which we just agreed it to be in7_input.
>
You didn't say Shunt-Voltage-Limit-Sum earlier. You said
Shunt-Voltage-Limit. I would agree that Shunt-Voltage-Limit-Sum is
associated with Shunt-Voltage-Sum, but, again, that is not what you
said earlier. Confused :-(
Guenter
next prev parent reply other threads:[~2019-09-12 22:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 0:28 ABI for these two registers? Nicolin Chen
2019-09-12 18:32 ` Guenter Roeck
2019-09-12 21:09 ` Nicolin Chen
2019-09-12 22:09 ` Guenter Roeck [this message]
2019-09-12 22:45 ` Nicolin Chen
2019-09-13 0:12 ` Nicolin Chen
2019-10-01 22:17 ` Nicolin Chen
2019-10-03 5:03 ` Guenter Roeck
2019-10-07 22:54 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190912220947.GA8072@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.