From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 3/3] net/if-mtu-change.sh: set LTP_TIMEOUT
Date: Fri, 13 Sep 2019 12:41:42 +0200 [thread overview]
Message-ID: <20190913104142.GA598@dell5510> (raw)
In-Reply-To: <1568368812.3306.7.camel@suse.de>
Hi Clements,
> > +LTP_TIMEOUT=$(((CHANGE_INTERVAL + 30) * MTU_CHANGE_TIMES))
> ^
> TST_TIMEOUT
> At least I would go with TST_ instead of LTP_ as the prefix TST_ means
> for me Libray and LTP_ user. This apply to some other places of this
> patchset.
Good point. Metan, do we want TST_TIMEOUT for library and LTP_TIMEOUT_MUL for
user? That's a bit strange, but I'd be for it.
LTP_* is for user to define (that's actually not true for tst_net.sh)
and TST_* for test definitions in script.
Kind regards,
Petr
prev parent reply other threads:[~2019-09-13 10:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 20:13 [LTP] [PATCH 0/3] LTP_TIMEOUT for shell API Petr Vorel
2019-09-12 20:13 ` [LTP] [PATCH 1/3] shell: Add tst_is_num() Petr Vorel
2019-09-12 20:13 ` [LTP] [PATCH 2/3] shell: Introduce LTP_TIMEOUT variable Petr Vorel
2019-09-13 10:26 ` Cristian Marussi
2019-09-13 10:46 ` Petr Vorel
2019-09-12 20:13 ` [LTP] [PATCH 3/3] net/if-mtu-change.sh: set LTP_TIMEOUT Petr Vorel
2019-09-13 10:00 ` Clemens Famulla-Conrad
2019-09-13 10:41 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913104142.GA598@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.