From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 220F5C49ED7 for ; Fri, 13 Sep 2019 13:55:06 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7BD320640 for ; Fri, 13 Sep 2019 13:55:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="iK98qwUe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7BD320640 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=ksummit-discuss-bounces@lists.linuxfoundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 99841FE0; Fri, 13 Sep 2019 13:55:05 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 5F065FDE for ; Fri, 13 Sep 2019 13:55:04 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 0043C7DB for ; Fri, 13 Sep 2019 13:55:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bNVVCafqJkMcKoP1y59HFv8nRZ31wfx1kpQ64ijtqic=; b=iK98qwUe7lOp1d7EKY7SRunR0 JlOgLWm5Fu6g9XFQG1KRkDv+Y0UkI6LgXnV+4TLv+uqQqp6SjUZHhy342WFPU8ErtM2c2hWxh3j2U lJkoc/JImKg7rfJvB54cPZVHIS2vg1E8CjdL09vS+vcN/EPqDA6k44scEudr4qd+vzgrMsH6GPHqW 3+p4AYZdLaRyJ4ygVLqG/8QJ4f7VmWIqojyGf+5liR/oIEh4qx3+FOVFg0iAMnHsPuk7vCxcztdgV JbKDP0E9YgdjmUVjZ9hIkTbva1WtTMDiWSiwibb4ud+JDJhkstCYHyPLTWw25+wp37jEmVhG08IJ6 PAZ5vnqfQ==; Received: from 177.96.232.144.dynamic.adsl.gvt.net.br ([177.96.232.144] helo=coco.lan) by bombadil.infradead.org with esmtpsa (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8m2I-0003uH-Lp; Fri, 13 Sep 2019 13:54:55 +0000 Date: Fri, 13 Sep 2019 10:54:46 -0300 From: Mauro Carvalho Chehab To: Matthew Wilcox Message-ID: <20190913105446.2b7af558@coco.lan> In-Reply-To: References: <156821692280.2951081.18036584954940423225.stgit@dwillia2-desk3.amr.corp.intel.com> <6fe45562-9493-25cf-afdb-6c0e702a49b4@acm.org> <44c08faf43fa77fb271f8dbb579079fb09007716.camel@perches.com> <74984dc0-d5e4-f272-34b9-9a78619d5a83@acm.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Cc: Dave Jiang , Bart Van Assche , ksummit-discuss@lists.linuxfoundation.org, linux-nvdimm@lists.01.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Vishal Verma , Dmitry Vyukov , Steve French , "Tobin C. Harding" Subject: Re: [Ksummit-discuss] [PATCH v2 0/3] Maintainer Entry Profiles X-BeenThere: ksummit-discuss@lists.linuxfoundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ksummit-discuss-bounces@lists.linuxfoundation.org Errors-To: ksummit-discuss-bounces@lists.linuxfoundation.org Em Fri, 13 Sep 2019 08:56:30 -0400 Matthew Wilcox escreveu: > It's easy enough to move the kernel-doc warnings out from under W=1. I only > out them there to avoid overwhelming us with new warnings. If they're > mostly fixed now, let's make checking them the default. Didn't try doing it kernelwide, but for media we do use W=1 by default, on our CI instance. There's a few warnings at EDAC, but they all seem easy enough to be fixed. So, from my side, I'm all to make W=1 default. Regards, Mauro > > On Thu., Sep. 12, 2019, 16:01 Bart Van Assche, wrote: > > > On 9/12/19 8:34 AM, Joe Perches wrote: > > > On Thu, 2019-09-12 at 14:31 +0100, Bart Van Assche wrote: > > >> On 9/11/19 5:40 PM, Martin K. Petersen wrote: > > >>> * The patch must compile without warnings (make C=1 > > CF="-D__CHECK_ENDIAN__") > > >>> and does not incur any zeroday test robot complaints. > > >> > > >> How about adding W=1 to that make command? > > > > > > That's rather too compiler version dependent and new > > > warnings frequently get introduced by new compiler versions. > > > > I've never observed this myself. If a new compiler warning is added to > > gcc and if it produces warnings that are not useful for kernel code > > usually Linus or someone else is quick to suppress that warning. > > > > Another argument in favor of W=1 is that the formatting of kernel-doc > > headers is checked only if W=1 is passed to make. > > > > Bart. > > > > _______________________________________________ > > Ksummit-discuss mailing list > > Ksummit-discuss@lists.linuxfoundation.org > > https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss > > Thanks, Mauro _______________________________________________ Ksummit-discuss mailing list Ksummit-discuss@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AF8AC4CEC7 for ; Fri, 13 Sep 2019 13:55:06 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 331AE20640 for ; Fri, 13 Sep 2019 13:55:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="iK98qwUe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 331AE20640 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 0F975202E843A; Fri, 13 Sep 2019 06:55:00 -0700 (PDT) Received-SPF: Permerror (SPF Permanent Error: Void lookup limit of 2 exceeded) identity=mailfrom; client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=mchehab@kernel.org; receiver=linux-nvdimm@lists.01.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E682E202E8427 for ; Fri, 13 Sep 2019 06:54:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bNVVCafqJkMcKoP1y59HFv8nRZ31wfx1kpQ64ijtqic=; b=iK98qwUe7lOp1d7EKY7SRunR0 JlOgLWm5Fu6g9XFQG1KRkDv+Y0UkI6LgXnV+4TLv+uqQqp6SjUZHhy342WFPU8ErtM2c2hWxh3j2U lJkoc/JImKg7rfJvB54cPZVHIS2vg1E8CjdL09vS+vcN/EPqDA6k44scEudr4qd+vzgrMsH6GPHqW 3+p4AYZdLaRyJ4ygVLqG/8QJ4f7VmWIqojyGf+5liR/oIEh4qx3+FOVFg0iAMnHsPuk7vCxcztdgV JbKDP0E9YgdjmUVjZ9hIkTbva1WtTMDiWSiwibb4ud+JDJhkstCYHyPLTWw25+wp37jEmVhG08IJ6 PAZ5vnqfQ==; Received: from 177.96.232.144.dynamic.adsl.gvt.net.br ([177.96.232.144] helo=coco.lan) by bombadil.infradead.org with esmtpsa (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8m2I-0003uH-Lp; Fri, 13 Sep 2019 13:54:55 +0000 Date: Fri, 13 Sep 2019 10:54:46 -0300 From: Mauro Carvalho Chehab To: Matthew Wilcox Subject: Re: [Ksummit-discuss] [PATCH v2 0/3] Maintainer Entry Profiles Message-ID: <20190913105446.2b7af558@coco.lan> In-Reply-To: References: <156821692280.2951081.18036584954940423225.stgit@dwillia2-desk3.amr.corp.intel.com> <6fe45562-9493-25cf-afdb-6c0e702a49b4@acm.org> <44c08faf43fa77fb271f8dbb579079fb09007716.camel@perches.com> <74984dc0-d5e4-f272-34b9-9a78619d5a83@acm.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-BeenThere: linux-nvdimm@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Linux-nvdimm developer list." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bart Van Assche , ksummit-discuss@lists.linuxfoundation.org, linux-nvdimm@lists.01.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Dmitry Vyukov , Joe Perches , Steve French , "Tobin C. Harding" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" Em Fri, 13 Sep 2019 08:56:30 -0400 Matthew Wilcox escreveu: > It's easy enough to move the kernel-doc warnings out from under W=1. I only > out them there to avoid overwhelming us with new warnings. If they're > mostly fixed now, let's make checking them the default. Didn't try doing it kernelwide, but for media we do use W=1 by default, on our CI instance. There's a few warnings at EDAC, but they all seem easy enough to be fixed. So, from my side, I'm all to make W=1 default. Regards, Mauro > > On Thu., Sep. 12, 2019, 16:01 Bart Van Assche, wrote: > > > On 9/12/19 8:34 AM, Joe Perches wrote: > > > On Thu, 2019-09-12 at 14:31 +0100, Bart Van Assche wrote: > > >> On 9/11/19 5:40 PM, Martin K. Petersen wrote: > > >>> * The patch must compile without warnings (make C=1 > > CF="-D__CHECK_ENDIAN__") > > >>> and does not incur any zeroday test robot complaints. > > >> > > >> How about adding W=1 to that make command? > > > > > > That's rather too compiler version dependent and new > > > warnings frequently get introduced by new compiler versions. > > > > I've never observed this myself. If a new compiler warning is added to > > gcc and if it produces warnings that are not useful for kernel code > > usually Linus or someone else is quick to suppress that warning. > > > > Another argument in favor of W=1 is that the formatting of kernel-doc > > headers is checked only if W=1 is passed to make. > > > > Bart. > > > > _______________________________________________ > > Ksummit-discuss mailing list > > Ksummit-discuss@lists.linuxfoundation.org > > https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss > > Thanks, Mauro _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74D53C4CEC8 for ; Fri, 13 Sep 2019 13:55:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E7A420830 for ; Fri, 13 Sep 2019 13:55:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568382906; bh=BHBg0k71VHbv9SgctzdWgVn1sdAemXeUVtSK9KI7bNk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=zJ9UBbE9nd9+qWqJods9HqROyuGAN4/D+ScErj3E7rJtZkfSDFqfEuN8LRraVCFeZ 6713TUO8CUbxx5bhifMd/cUrjQd+5in9EOmS231HlV28KXGyF6R6Erj+QToP5Pq8D9 uTHwOGiAEiu2+iL0eLXWbDe/UdrZ/TnYWJeyNAoI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390461AbfIMNzF (ORCPT ); Fri, 13 Sep 2019 09:55:05 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:37276 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388331AbfIMNzF (ORCPT ); Fri, 13 Sep 2019 09:55:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bNVVCafqJkMcKoP1y59HFv8nRZ31wfx1kpQ64ijtqic=; b=iK98qwUe7lOp1d7EKY7SRunR0 JlOgLWm5Fu6g9XFQG1KRkDv+Y0UkI6LgXnV+4TLv+uqQqp6SjUZHhy342WFPU8ErtM2c2hWxh3j2U lJkoc/JImKg7rfJvB54cPZVHIS2vg1E8CjdL09vS+vcN/EPqDA6k44scEudr4qd+vzgrMsH6GPHqW 3+p4AYZdLaRyJ4ygVLqG/8QJ4f7VmWIqojyGf+5liR/oIEh4qx3+FOVFg0iAMnHsPuk7vCxcztdgV JbKDP0E9YgdjmUVjZ9hIkTbva1WtTMDiWSiwibb4ud+JDJhkstCYHyPLTWw25+wp37jEmVhG08IJ6 PAZ5vnqfQ==; Received: from 177.96.232.144.dynamic.adsl.gvt.net.br ([177.96.232.144] helo=coco.lan) by bombadil.infradead.org with esmtpsa (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8m2I-0003uH-Lp; Fri, 13 Sep 2019 13:54:55 +0000 Date: Fri, 13 Sep 2019 10:54:46 -0300 From: Mauro Carvalho Chehab To: Matthew Wilcox Cc: Bart Van Assche , Joe Perches , "Martin K . Petersen" , Dan Williams , Dave Jiang , ksummit-discuss@lists.linuxfoundation.org, linux-nvdimm@lists.01.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Steve French , Vishal Verma , Dmitry Vyukov , "Tobin C. Harding" Subject: Re: [Ksummit-discuss] [PATCH v2 0/3] Maintainer Entry Profiles Message-ID: <20190913105446.2b7af558@coco.lan> In-Reply-To: References: <156821692280.2951081.18036584954940423225.stgit@dwillia2-desk3.amr.corp.intel.com> <6fe45562-9493-25cf-afdb-6c0e702a49b4@acm.org> <44c08faf43fa77fb271f8dbb579079fb09007716.camel@perches.com> <74984dc0-d5e4-f272-34b9-9a78619d5a83@acm.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, 13 Sep 2019 08:56:30 -0400 Matthew Wilcox escreveu: > It's easy enough to move the kernel-doc warnings out from under W=1. I only > out them there to avoid overwhelming us with new warnings. If they're > mostly fixed now, let's make checking them the default. Didn't try doing it kernelwide, but for media we do use W=1 by default, on our CI instance. There's a few warnings at EDAC, but they all seem easy enough to be fixed. So, from my side, I'm all to make W=1 default. Regards, Mauro > > On Thu., Sep. 12, 2019, 16:01 Bart Van Assche, wrote: > > > On 9/12/19 8:34 AM, Joe Perches wrote: > > > On Thu, 2019-09-12 at 14:31 +0100, Bart Van Assche wrote: > > >> On 9/11/19 5:40 PM, Martin K. Petersen wrote: > > >>> * The patch must compile without warnings (make C=1 > > CF="-D__CHECK_ENDIAN__") > > >>> and does not incur any zeroday test robot complaints. > > >> > > >> How about adding W=1 to that make command? > > > > > > That's rather too compiler version dependent and new > > > warnings frequently get introduced by new compiler versions. > > > > I've never observed this myself. If a new compiler warning is added to > > gcc and if it produces warnings that are not useful for kernel code > > usually Linus or someone else is quick to suppress that warning. > > > > Another argument in favor of W=1 is that the formatting of kernel-doc > > headers is checked only if W=1 is passed to make. > > > > Bart. > > > > _______________________________________________ > > Ksummit-discuss mailing list > > Ksummit-discuss@lists.linuxfoundation.org > > https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss > > Thanks, Mauro