From: Kalle Valo <kvalo@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
"David S . Miller" <davem@davemloft.net>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: rtl8821ae: make array static const and remove redundant assignment
Date: Fri, 13 Sep 2019 13:44:40 +0000 [thread overview]
Message-ID: <20190913134440.17711607CA@smtp.codeaurora.org> (raw)
In-Reply-To: <20190905150022.3609-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The array channel_all can be make static const rather than populating
> it on the stack, this makes the code smaller. Also, variable place
> is being initialized with a value that is never read, so this assignment
> is redundant and can be removed.
>
> Before:
> text data bss dec hex filename
> 118537 9591 0 128128 1f480 realtek/rtlwifi/rtl8821ae/phy.o
>
> After:
> text data bss dec hex filename
> 118331 9687 0 128018 1f412 realtek/rtlwifi/rtl8821ae/phy.o
>
> Saves 110 bytes, (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
569ce0a486fd rtlwifi: rtl8821ae: make array static const and remove redundant assignment
--
https://patchwork.kernel.org/patch/11133295/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
"David S . Miller" <davem@davemloft.net>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: rtl8821ae: make array static const and remove redundant assignment
Date: Fri, 13 Sep 2019 13:44:40 +0000 (UTC) [thread overview]
Message-ID: <20190913134440.17711607CA@smtp.codeaurora.org> (raw)
In-Reply-To: <20190905150022.3609-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The array channel_all can be make static const rather than populating
> it on the stack, this makes the code smaller. Also, variable place
> is being initialized with a value that is never read, so this assignment
> is redundant and can be removed.
>
> Before:
> text data bss dec hex filename
> 118537 9591 0 128128 1f480 realtek/rtlwifi/rtl8821ae/phy.o
>
> After:
> text data bss dec hex filename
> 118331 9687 0 128018 1f412 realtek/rtlwifi/rtl8821ae/phy.o
>
> Saves 110 bytes, (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
569ce0a486fd rtlwifi: rtl8821ae: make array static const and remove redundant assignment
--
https://patchwork.kernel.org/patch/11133295/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-09-13 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 15:00 [PATCH] rtlwifi: rtl8821ae: make array static const and remove redundant assignment Colin King
2019-09-05 15:00 ` Colin King
2019-09-13 13:44 ` Kalle Valo [this message]
2019-09-13 13:44 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913134440.17711607CA@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.