All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Yi Zhang <yi.zhang@redhat.com>
Cc: linux-nvme@lists.infradead.org
Subject: Re: incorrect sysfs reported by realpath for nvme disk when nvme-core:multipath enabled
Date: Fri, 13 Sep 2019 11:56:38 -0600	[thread overview]
Message-ID: <20190913175637.GC17139@keith-busch> (raw)
In-Reply-To: <1137688987.11971676.1568396450210.JavaMail.zimbra@redhat.com>

On Fri, Sep 13, 2019 at 01:40:50PM -0400, Yi Zhang wrote:
> # realpath  /sys/dev/block/259:0
> /sys/devices/pci0000:ae/0000:ae:00.0/0000:af:00.0/nvme/nvme1/nvme0n1   --------> should it be /sys/devices/pci0000:ae/0000:ae:00.0/0000:af:00.0/nvme/nvme0/nvme0n1 ?

The sysfs links are correct. The controller-namespacenaming is just not
related, which is what you're observing.

This was confusing to enough people that we've since changed the naming
to something people expect to see, but that's staged in 5.4. Given the
number of people who find this confusing, this might be worth making a
stable patch.
 
> # realpath  /sys/dev/block/259:2
> /sys/devices/virtual/nvme-subsystem/nvme-subsys1/nvme1n1               --------> No pci address returned, bug?

For mulitpath capable controllers, the parent of a namespace is the
subsystem rather than a controller. The subsystem is a virtual device
that doesn't have a physical pci address.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2019-09-13 17:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1753358694.11967186.1568394608486.JavaMail.zimbra@redhat.com>
2019-09-13 17:40 ` incorrect sysfs reported by realpath for nvme disk when nvme-core:multipath enabled Yi Zhang
2019-09-13 17:56   ` Keith Busch [this message]
2019-09-13 18:43     ` Sagi Grimberg
2019-09-14 15:19       ` Keith Busch
2019-09-16  9:30         ` Yi Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190913175637.GC17139@keith-busch \
    --to=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=yi.zhang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.