From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>
Subject: Re: [nft PATCH v2] parser_bison: Fix 'exists' keyword on Big Endian
Date: Fri, 13 Sep 2019 22:53:44 +0200 [thread overview]
Message-ID: <20190913205344.GD10656@breakpoint.cc> (raw)
In-Reply-To: <20190913184429.21605-1-phil@nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> Size value passed to constant_expr_alloc() must correspond with actual
> data size, otherwise wrong portion of data will be taken later when
> serializing into netlink message.
>
> Booleans require really just a bit, but make type of boolean_keys be
> uint8_t (introducing new 'val8' name for it) and pass the data length
> using sizeof() to avoid any magic numbers.
>
> While being at it, fix len value in parser_json.c as well although it
> worked before due to the value being rounded up to the next multiple of
> 8.
Looks good, thanks Phil.
next prev parent reply other threads:[~2019-09-13 20:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 18:44 [nft PATCH v2] parser_bison: Fix 'exists' keyword on Big Endian Phil Sutter
2019-09-13 20:53 ` Florian Westphal [this message]
2019-09-13 20:56 ` Phil Sutter
2019-09-13 22:35 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913205344.GD10656@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.