Re: [MPTCP] [PATCH RFC] mptcp: allow dumping subflow context to userspace

[Florian Westphal <fw at strlen.de>]

[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]

Davide Caratti <dcaratti(a)redhat.com> wrote:
> On Thu, 2019-09-12 at 18:50 +0200, Davide Caratti wrote:
> > add ulp-specific diagnostic functions, so that subflow information can be
> > dumped to userspace programs like 'ss'.
> 
> for the record: iproute2 support is also on the way, but also in this case
> the first step will be in ktls. This patch exposes token, local/remote
> keys, and some of the bitfield members. What do you think it's reasonable
> exposing to users of 'ss -i' ?

The MPTCP (parent/meta) socket data, e.g. the DSS would be good.

Once Paolo retrans is in, we could also extend that to expose
information about MPTCP-Level events (rather than subflow stats).

This is a great start though.  I guess it might be good to expose
how much more data the current mapping expects.

Wrt. local/remote keys, what is the use case?

I'm asking because some people get nervous when you add an api to
expose 'secret keys'.

If there is no clear use-case i'd rather not expose them for now,
it can be added later if needed.