All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: kbuild-all@01.org, f.fainelli@gmail.com,
	vivien.didelot@gmail.com, andrew@lunn.ch, davem@davemloft.net,
	vinicius.gomes@intel.com, vedang.patel@intel.com,
	richardcochran@gmail.com, weifeng.voon@intel.com,
	jiri@mellanox.com, m-karicheri2@ti.com, Jose.Abreu@synopsys.com,
	ilias.apalodimas@linaro.org, jhs@mojatatu.com,
	xiyou.wangcong@gmail.com, kurt.kanzenbach@linutronix.de,
	joergen.andreasen@microchip.com, netdev@vger.kernel.org,
	Vladimir Oltean <olteanv@gmail.com>
Subject: Re: [PATCH v2 net-next 6/7] net: dsa: sja1105: Configure the Time-Aware Scheduler via tc-taprio offload
Date: Sat, 14 Sep 2019 17:47:12 +0800	[thread overview]
Message-ID: <201909141759.R0atrZ2e%lkp@intel.com> (raw)
In-Reply-To: <20190914011802.1602-7-olteanv@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 4173 bytes --]

Hi Vladimir,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Vladimir-Oltean/tc-taprio-offload-for-SJA1105-DSA/20190914-154650
config: i386-randconfig-b001-201936 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-11) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from drivers/net/dsa/sja1105/sja1105.h:23:0,
                    from drivers/net/dsa/sja1105/sja1105_spi.c:8:
>> drivers/net/dsa/sja1105/sja1105_tas.h:38:45: warning: 'struct sja1105_private' declared inside parameter list will not be visible outside of this definition or declaration
    static inline void sja1105_tas_setup(struct sja1105_private *priv) { }
                                                ^~~~~~~~~~~~~~~
   drivers/net/dsa/sja1105/sja1105_tas.h:40:48: warning: 'struct sja1105_private' declared inside parameter list will not be visible outside of this definition or declaration
    static inline void sja1105_tas_teardown(struct sja1105_private *priv) { }
                                                   ^~~~~~~~~~~~~~~
--
   In file included from drivers/net/dsa/sja1105/sja1105.h:23:0,
                    from drivers/net/dsa/sja1105/sja1105_main.c:24:
>> drivers/net/dsa/sja1105/sja1105_tas.h:38:45: warning: 'struct sja1105_private' declared inside parameter list will not be visible outside of this definition or declaration
    static inline void sja1105_tas_setup(struct sja1105_private *priv) { }
                                                ^~~~~~~~~~~~~~~
   drivers/net/dsa/sja1105/sja1105_tas.h:40:48: warning: 'struct sja1105_private' declared inside parameter list will not be visible outside of this definition or declaration
    static inline void sja1105_tas_teardown(struct sja1105_private *priv) { }
                                                   ^~~~~~~~~~~~~~~
   drivers/net/dsa/sja1105/sja1105_main.c: In function 'sja1105_teardown':
>> drivers/net/dsa/sja1105/sja1105_main.c:1731:23: error: passing argument 1 of 'sja1105_tas_teardown' from incompatible pointer type [-Werror=incompatible-pointer-types]
     sja1105_tas_teardown(priv);
                          ^~~~
   In file included from drivers/net/dsa/sja1105/sja1105.h:23:0,
                    from drivers/net/dsa/sja1105/sja1105_main.c:24:
   drivers/net/dsa/sja1105/sja1105_tas.h:40:20: note: expected 'struct sja1105_private *' but argument is of type 'struct sja1105_private *'
    static inline void sja1105_tas_teardown(struct sja1105_private *priv) { }
                       ^~~~~~~~~~~~~~~~~~~~
   drivers/net/dsa/sja1105/sja1105_main.c: In function 'sja1105_probe':
>> drivers/net/dsa/sja1105/sja1105_main.c:2215:20: error: passing argument 1 of 'sja1105_tas_setup' from incompatible pointer type [-Werror=incompatible-pointer-types]
     sja1105_tas_setup(priv);
                       ^~~~
   In file included from drivers/net/dsa/sja1105/sja1105.h:23:0,
                    from drivers/net/dsa/sja1105/sja1105_main.c:24:
   drivers/net/dsa/sja1105/sja1105_tas.h:38:20: note: expected 'struct sja1105_private *' but argument is of type 'struct sja1105_private *'
    static inline void sja1105_tas_setup(struct sja1105_private *priv) { }
                       ^~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/sja1105_tas_teardown +1731 drivers/net/dsa/sja1105/sja1105_main.c

  1726	
  1727	static void sja1105_teardown(struct dsa_switch *ds)
  1728	{
  1729		struct sja1105_private *priv = ds->priv;
  1730	
> 1731		sja1105_tas_teardown(priv);
  1732		cancel_work_sync(&priv->tagger_data.rxtstamp_work);
  1733		skb_queue_purge(&priv->tagger_data.skb_rxtstamp_queue);
  1734		sja1105_ptp_clock_unregister(priv);
  1735		sja1105_static_config_free(&priv->static_config);
  1736	}
  1737	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31701 bytes --]

  reply	other threads:[~2019-09-14  9:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-14  1:17 [PATCH v2 net-next 0/7] tc-taprio offload for SJA1105 DSA Vladimir Oltean
2019-09-14  1:17 ` [PATCH v2 net-next 1/7] taprio: Add support for hardware offloading Vladimir Oltean
2019-09-14  1:17 ` [PATCH v2 net-next 2/7] net: dsa: Pass ndo_setup_tc slave callback to drivers Vladimir Oltean
2019-09-14  2:59   ` Florian Fainelli
2019-09-16  9:31   ` Ilias Apalodimas
2019-09-16  9:53     ` Vladimir Oltean
2019-09-14  1:17 ` [PATCH v2 net-next 3/7] net: dsa: sja1105: Add static config tables for scheduling Vladimir Oltean
2019-09-14  1:17 ` [PATCH v2 net-next 4/7] net: dsa: sja1105: Advertise the 8 TX queues Vladimir Oltean
2019-09-14  1:18 ` [PATCH v2 net-next 5/7] net: dsa: sja1105: Make HOSTPRIO a kernel config Vladimir Oltean
2019-09-14  1:18 ` [PATCH v2 net-next 6/7] net: dsa: sja1105: Configure the Time-Aware Scheduler via tc-taprio offload Vladimir Oltean
2019-09-14  9:47   ` kbuild test robot [this message]
2019-09-14 13:40     ` Vladimir Oltean
2019-09-14  1:18 ` [PATCH v2 net-next 7/7] docs: net: dsa: sja1105: Add info about the time-aware scheduler Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201909141759.R0atrZ2e%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=Jose.Abreu@synopsys.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jhs@mojatatu.com \
    --cc=jiri@mellanox.com \
    --cc=joergen.andreasen@microchip.com \
    --cc=kbuild-all@01.org \
    --cc=kurt.kanzenbach@linutronix.de \
    --cc=m-karicheri2@ti.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=richardcochran@gmail.com \
    --cc=vedang.patel@intel.com \
    --cc=vinicius.gomes@intel.com \
    --cc=vivien.didelot@gmail.com \
    --cc=weifeng.voon@intel.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.