From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] error-report: Add info_report_once helper
Date: Sat, 14 Sep 2019 21:57:00 +0300 [thread overview]
Message-ID: <20190914185700.GI1508@uranus> (raw)
In-Reply-To: <87sgoy3emv.fsf@dusky.pond.sub.org>
On Sat, Sep 14, 2019 at 08:40:40PM +0200, Markus Armbruster wrote:
> You neglected to cc: the maintainer (me). I spotted this anyway, more
> or less by chance. Next time, please use scripts/get_maintainer.pl to
> find people you might want to cc:.
Ah, sorry for that. Will do next time, thanks!
> Cyrill Gorcunov <gorcunov@gmail.com> writes:
>
> > We already have error_report_once and warn_report_once,
> > thus lets add info_report_once to complement. Actually
> > I use this helper a lot so might be usefull for others.
> >
> > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
>
> Patch looks reasonable enough. However, the new info_report_once() and
> info_report_once_cond() aren't used. Your commit message suggests you
> have users in unpublished code. Is that correct?
Exactly. I work on yet unpublished but open source code
(https://src.openvz.org/projects/UP/repos/qemu/browse) to be
precise. But work is still in progress and hasn't been pushed
out.
You know I posted the patch simply because it might be
useful for someone and it looks a bit incomplete that
we have "warn/error once" but no info_once. Up to you
to decide if we need it in vanilla tree.
prev parent reply other threads:[~2019-09-14 18:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 15:43 [Qemu-devel] [PATCH] error-report: Add info_report_once helper Cyrill Gorcunov
2019-09-14 18:40 ` Markus Armbruster
2019-09-14 18:57 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190914185700.GI1508@uranus \
--to=gorcunov@gmail.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.