From: Jonathan Cameron <jic23@kernel.org>
To: Andrea Merello <andrea.merello@gmail.com>
Cc: paresh.chaudhary@rockwellcollins.com,
patrick.havelange@essensium.com, pmeerw@pmeerw.net,
lars@metafoo.de, knaack.h@gmx.de, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: max31856: add missing of_node and parent references to iio_dev
Date: Sun, 15 Sep 2019 13:27:32 +0100 [thread overview]
Message-ID: <20190915132732.776423d7@archlinux> (raw)
In-Reply-To: <20190909125817.17882-1-andrea.merello@gmail.com>
On Mon, 9 Sep 2019 14:58:17 +0200
Andrea Merello <andrea.merello@gmail.com> wrote:
> Adding missing indio_dev->dev.of_node references so that, in case multiple
> max31856 are present, users can get some clues to being able to distinguish
> each of them. While at it, add also the missing parent reference.
>
> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
>
> diff --git a/drivers/iio/temperature/max31856.c b/drivers/iio/temperature/max31856.c
> index f184ba5601d9..73ed550e3fc9 100644
> --- a/drivers/iio/temperature/max31856.c
> +++ b/drivers/iio/temperature/max31856.c
> @@ -284,6 +284,8 @@ static int max31856_probe(struct spi_device *spi)
> spi_set_drvdata(spi, indio_dev);
>
> indio_dev->info = &max31856_info;
> + indio_dev->dev.parent = &spi->dev;
> + indio_dev->dev.of_node = spi->dev.of_node;
> indio_dev->name = id->name;
> indio_dev->modes = INDIO_DIRECT_MODE;
> indio_dev->channels = max31856_channels;
prev parent reply other threads:[~2019-09-15 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 12:58 [PATCH] iio: max31856: add missing of_node and parent references to iio_dev Andrea Merello
2019-09-15 12:27 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190915132732.776423d7@archlinux \
--to=jic23@kernel.org \
--cc=andrea.merello@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=paresh.chaudhary@rockwellcollins.com \
--cc=patrick.havelange@essensium.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.