From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org
Subject: Re: [RFC/PATCH 0/1] Quadrature Encoder Support
Date: Sun, 15 Sep 2019 23:23:25 +0900 [thread overview]
Message-ID: <20190915142325.GA446150@icarus> (raw)
In-Reply-To: <20190915145347.42bfc393@archlinux>
On Sun, Sep 15, 2019 at 02:53:47PM +0100, Jonathan Cameron wrote:
> On Mon, 9 Sep 2019 15:16:04 +0300
> Felipe Balbi <felipe.balbi@linux.intel.com> wrote:
>
> > Hi,
> >
> > Here's a simple RFC for Intel's Quadrature Encoder. Let me make it clear
> > that I don't mean we should the following patch as is, rather I'd like
> > to open the discussion to, perhaps, extending Industrial Automation
> > Framework with support for Quadrature Encoders.
> >
> > Let me know if you think IIO would be correct place for such devices,
> > then I can start reworking the driver to provide an IIO-compliant
> > interface.
> >
> > I'm thinking we would need standard sysfs files for configuring the QEP
> > into single-shot QEP mode or buffered Capture mode, configure thresholds
> > and other details.
>
> Hi Felipe,
>
> Fairly recently, similar concerns that IIO didn't really suite these
> devices lead William to create a specific 'counters' subsystem.
> +CC William.
>
> It may not address all of your requirements yet, but I would imagine it
> is a better fit than IIO would ever be. We have moved all the older
> counter drivers out of IIO and across to this new subsystem.
>
> Thanks,
>
> Jonathan
Felipe,
Take a look at the Generic Counter interface, it may be what you need:
https://www.kernel.org/doc/html/latest/driver-api/generic-counter.html
There are some existing quadrature encoder counter devices using this
interface already; look at the files under drivers/counter for
reference.
This interface is still relatively new, so if you have any problems just
shoot me an email and I'll be happy to help. :-)
William Breathitt Gray
>
>
> >
> > Cheers
> >
> > Felipe Balbi (1):
> > misc: introduce intel QEP
> >
> > drivers/misc/Kconfig | 7 +
> > drivers/misc/Makefile | 1 +
> > drivers/misc/intel-qep.c | 813 +++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 821 insertions(+)
> > create mode 100644 drivers/misc/intel-qep.c
> >
>
next prev parent reply other threads:[~2019-09-15 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 12:16 [RFC/PATCH 0/1] Quadrature Encoder Support Felipe Balbi
2019-09-09 12:16 ` [RFC/PATCH 1/1] misc: introduce intel QEP Felipe Balbi
2019-09-15 13:53 ` [RFC/PATCH 0/1] Quadrature Encoder Support Jonathan Cameron
2019-09-15 14:23 ` William Breathitt Gray [this message]
2019-09-16 6:16 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190915142325.GA446150@icarus \
--to=vilhelm.gray@gmail.com \
--cc=felipe.balbi@linux.intel.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.