From: Wei Yang <richardw.yang@linux.intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, rth@twiddle.net, mst@redhat.com,
Wei Yang <richardw.yang@linux.intel.com>,
Wei Yang <richard.weiyang@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 2/6] exec.c: remove an unnecessary assert on PHYS_MAP_NODE_NIL in phys_map_node_alloc()
Date: Mon, 16 Sep 2019 10:02:28 +0800 [thread overview]
Message-ID: <20190916020228.GA8247@richard> (raw)
In-Reply-To: <20793db8-7cfc-2a9d-aa60-5020e84a5950@redhat.com>
On Fri, Sep 13, 2019 at 11:12:05AM +0200, Paolo Bonzini wrote:
>On 13/09/19 01:02, Wei Yang wrote:
>> It shows PHYS_MAP_NODE_NIL may represents more node the tree could hold.
>
>Which is good, it means the assert can trigger.
>
Per my understanding, it means the assert can't trigger.
>> The assert here is not harmful, while maybe we can have a better way to handle
>> it?
>
>I don't know... The assert just says "careful, someone treats
>PHYS_MAP_NODE_NIL specially!". It's documentation too.
>
>Paolo
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2019-09-16 2:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190321082555.21118-1-richardw.yang@linux.intel.com>
2019-04-22 0:59 ` [Qemu-devel] [PATCH 0/6] Refine exec Wei Yang
2019-04-22 0:59 ` Wei Yang
2019-08-19 3:06 ` Wei Yang
2019-08-22 10:25 ` Paolo Bonzini
2019-08-22 22:31 ` Wei Yang
[not found] ` <20190321082555.21118-3-richardw.yang@linux.intel.com>
2019-08-22 10:24 ` [Qemu-devel] [PATCH 2/6] exec.c: remove an unnecessary assert on PHYS_MAP_NODE_NIL in phys_map_node_alloc() Paolo Bonzini
2019-08-23 1:07 ` Wei Yang
2019-09-12 2:51 ` Wei Yang
2019-09-12 12:42 ` Paolo Bonzini
2019-09-12 23:02 ` Wei Yang
2019-09-13 9:12 ` Paolo Bonzini
2019-09-16 2:02 ` Wei Yang [this message]
2019-09-16 7:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916020228.GA8247@richard \
--to=richardw.yang@linux.intel.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.weiyang@gmail.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.