From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AA46C49ED7 for ; Mon, 16 Sep 2019 07:51:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7581D20650 for ; Mon, 16 Sep 2019 07:51:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725912AbfIPHv4 (ORCPT ); Mon, 16 Sep 2019 03:51:56 -0400 Received: from verein.lst.de ([213.95.11.211]:42930 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725847AbfIPHvz (ORCPT ); Mon, 16 Sep 2019 03:51:55 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 2AE1668B05; Mon, 16 Sep 2019 09:51:52 +0200 (CEST) Date: Mon, 16 Sep 2019 09:51:51 +0200 From: Christoph Hellwig To: Max Gurtovoy Cc: linux-block@vger.kernel.org, axboe@kernel.dk, martin.petersen@oracle.com, linux-nvme@lists.infradead.org, keith.busch@intel.com, hch@lst.de, sagi@grimberg.me, shlomin@mellanox.com, israelr@mellanox.com Subject: Re: [PATCH v6 1/2] block: use symbolic constants for t10_pi type Message-ID: <20190916075151.GA25796@lst.de> References: <1568493253-18142-1-git-send-email-maxg@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1568493253-18142-1-git-send-email-maxg@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sat, Sep 14, 2019 at 11:34:12PM +0300, Max Gurtovoy wrote: > Reviewed-by: Martin K. Petersen > Signed-off-by: Max Gurtovoy A little bit of a changelog would have been nice, but otherwise this looks fine to me: Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EEBBC49ED7 for ; Mon, 16 Sep 2019 07:52:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1473F20650 for ; Mon, 16 Sep 2019 07:51:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k+l3iNyS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1473F20650 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YZ1gzg/BGioznuJjBFIePwUgWNANIrryha5GciwAS04=; b=k+l3iNySE4ZAKn Ysjbr7wSmG5zg9v+TLyDHmMDL9W/1ANv+d4WnOLDPXGoygk84JHQc+V/br5dhCcRCjtozxTPMVEtG YH7zhSi1AFv/9UMzxC1F29p/96755xZAoti+HL0/rylxDTaHzq7xVW3rgFIiDqYpvKhSWuuqGaJiR XOU6884x4TP92wEz2LnawcO2gfEryknxRXXkGDiCfeh370GozRYjqv4b/ivQNkZwvtXhTR6A9oYA6 r20KaRS4maUFJkgMWoioF0BMvg7G919e2sISycIaGwgXSdn1PQKcKv0WcR0vTeZKJxhwrRUHRd6oH sVizucOhRVnHVsAPK+1Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9lni-0000j9-Mj; Mon, 16 Sep 2019 07:51:58 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9lnf-0000iR-O9 for linux-nvme@lists.infradead.org; Mon, 16 Sep 2019 07:51:57 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 2AE1668B05; Mon, 16 Sep 2019 09:51:52 +0200 (CEST) Date: Mon, 16 Sep 2019 09:51:51 +0200 From: Christoph Hellwig To: Max Gurtovoy Subject: Re: [PATCH v6 1/2] block: use symbolic constants for t10_pi type Message-ID: <20190916075151.GA25796@lst.de> References: <1568493253-18142-1-git-send-email-maxg@mellanox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1568493253-18142-1-git-send-email-maxg@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190916_005155_940106_24D53544 X-CRM114-Status: UNSURE ( 6.40 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, keith.busch@intel.com, sagi@grimberg.me, martin.petersen@oracle.com, israelr@mellanox.com, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, shlomin@mellanox.com, hch@lst.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Sat, Sep 14, 2019 at 11:34:12PM +0300, Max Gurtovoy wrote: > Reviewed-by: Martin K. Petersen > Signed-off-by: Max Gurtovoy A little bit of a changelog would have been nice, but otherwise this looks fine to me: Reviewed-by: Christoph Hellwig _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme