From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF202C49ED7 for ; Mon, 16 Sep 2019 08:01:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E3EC206C2 for ; Mon, 16 Sep 2019 08:01:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726898AbfIPIBr (ORCPT ); Mon, 16 Sep 2019 04:01:47 -0400 Received: from verein.lst.de ([213.95.11.211]:42998 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726075AbfIPIBr (ORCPT ); Mon, 16 Sep 2019 04:01:47 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id C377A68B05; Mon, 16 Sep 2019 10:01:42 +0200 (CEST) Date: Mon, 16 Sep 2019 10:01:42 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Max Gurtovoy , linux-block@vger.kernel.org, martin.petersen@oracle.com, linux-nvme@lists.infradead.org, keith.busch@intel.com, hch@lst.de, sagi@grimberg.me, shlomin@mellanox.com, israelr@mellanox.com Subject: Re: [PATCH v5 2/2] block: centralize PI remapping logic to the block layer Message-ID: <20190916080142.GA25898@lst.de> References: <1568215397-15496-1-git-send-email-maxg@mellanox.com> <1568215397-15496-2-git-send-email-maxg@mellanox.com> <380932df-2119-ad86-8bb2-3eccb005c949@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <380932df-2119-ad86-8bb2-3eccb005c949@kernel.dk> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Sep 11, 2019 at 04:01:11PM -0600, Jens Axboe wrote: > While I like the idea of centralizing stuff like this, I'm also not > happy with adding checks like this to the fast path. But I guess it's > still better than stuff it in drivers. Let's put it that way - we move the check from our two most commonly drivers (one of those also is our most performance sensitive) to common code. I think this should generally be a net win? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C07A9C4CEC7 for ; Mon, 16 Sep 2019 08:01:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9742B20890 for ; Mon, 16 Sep 2019 08:01:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Gbtrys4g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9742B20890 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zUaocTagvAkMQ0mQTAUZqQTPC3px+EzPbJWN8FocRbw=; b=Gbtrys4gmO83dY YwC5OQJLYnTf/HZQyRb2HBJ90AkjmQ2Y65qbauGQUi5msGZ+bsPkVU0ZG4eXVrb2EKQ4nYuPcyt1B egoIm5u7bAyUv/22Ale2c+ef1rZLHCk/EHmTxS42dDNY/HZBdo+lAdGI/25yg8y9G7Nz+zeuGaS5Z i+MtyHluWiSL2evm8giwxtw+km9Ajf6I8vyrEKH66hqHtEcVJ42P0VoBtNkmOj8fl1q9w4L0o5aPm ac1A5VzDBvI8yZC4jLBlMd5Jubm3kdlDS5B4HTG4wDG1ifWIMtAdkYyVDEpjgVHwD0pbqtHsWKGzZ BSGb1A3zvPNREgozsacw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9lxE-0004qh-K9; Mon, 16 Sep 2019 08:01:48 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9lxC-0004qI-BF for linux-nvme@lists.infradead.org; Mon, 16 Sep 2019 08:01:47 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id C377A68B05; Mon, 16 Sep 2019 10:01:42 +0200 (CEST) Date: Mon, 16 Sep 2019 10:01:42 +0200 From: Christoph Hellwig To: Jens Axboe Subject: Re: [PATCH v5 2/2] block: centralize PI remapping logic to the block layer Message-ID: <20190916080142.GA25898@lst.de> References: <1568215397-15496-1-git-send-email-maxg@mellanox.com> <1568215397-15496-2-git-send-email-maxg@mellanox.com> <380932df-2119-ad86-8bb2-3eccb005c949@kernel.dk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <380932df-2119-ad86-8bb2-3eccb005c949@kernel.dk> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190916_010146_539805_866935A9 X-CRM114-Status: UNSURE ( 7.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: keith.busch@intel.com, sagi@grimberg.me, martin.petersen@oracle.com, israelr@mellanox.com, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, shlomin@mellanox.com, Max Gurtovoy , hch@lst.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Sep 11, 2019 at 04:01:11PM -0600, Jens Axboe wrote: > While I like the idea of centralizing stuff like this, I'm also not > happy with adding checks like this to the fast path. But I guess it's > still better than stuff it in drivers. Let's put it that way - we move the check from our two most commonly drivers (one of those also is our most performance sensitive) to common code. I think this should generally be a net win? _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme