From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68A52C49ED7 for ; Mon, 16 Sep 2019 14:05:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A2A12067D for ; Mon, 16 Sep 2019 14:05:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A2A12067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9rco-00088H-M9 for qemu-devel@archiver.kernel.org; Mon, 16 Sep 2019 10:05:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45763) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9rWU-0002iB-Oc for qemu-devel@nongnu.org; Mon, 16 Sep 2019 09:58:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i9rWS-0008Vm-1Q for qemu-devel@nongnu.org; Mon, 16 Sep 2019 09:58:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35628) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i9rWR-0008Sr-Or; Mon, 16 Sep 2019 09:58:31 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4E1A91107; Mon, 16 Sep 2019 13:58:30 +0000 (UTC) Received: from t460s.redhat.com (ovpn-117-103.ams2.redhat.com [10.36.117.103]) by smtp.corp.redhat.com (Postfix) with ESMTP id 280E01001B13; Mon, 16 Sep 2019 13:58:06 +0000 (UTC) From: David Hildenbrand To: qemu-devel@nongnu.org Date: Mon, 16 Sep 2019 15:57:37 +0200 Message-Id: <20190916135806.1269-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 16 Sep 2019 13:58:30 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v3 00/29] s390x/tcg: mem_helper: Fault-safe handling X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Weimer , Thomas Huth , David Hildenbrand , =?UTF-8?q?Dan=20Hor=C3=A1k?= , Cornelia Huck , Stefano Brivio , qemu-s390x@nongnu.org, Cole Robinson , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This series fixes a bunch of issues related to some mem helpers and makes sure that they are fault-safe, meaning no system state is modified in cas= e a fault is triggered. I can spot tons of other issues with other mem helpers that will have to be fixed later. Also, fault-safe handling for some instructions (especially TR) might be harder to implement (you don't know what will actually be accessed upfront - we might need a buffer and go over inputs twice). Focusing on the MOVE instructions for now. ---- Newer versions of glibc use memcpy() in memmove() for forward moves. The implementation makese use of MVC. The TCG implementation of MVC is currently not able to handle faults reliably when crossing pages. MVC can cross with 256 bytes at most two pages. In case we get a fault on the second page, we already moved data. When continuing after the fault we might try to move already overwritten data, which is very bad in case we have overlapping data on a forward move. Triggered for now only by rpmbuild (crashes when checking the spec file) and rpm (database corruptions). This fixes installing Fedora rawhide (31) under TCG. This was horrible to debug as it barely triggers and we fail at completel= y different places. Cc: Stefano Brivio Cc: Florian Weimer Cc: Dan Hor=C3=A1k Cc: Cole Robinson v2 -> v3: - "s390x/tcg: MVCL: Zero out unused bits of address" -- Do single deposit for 24/31-bit - "s390x/tcg: MVCL: Process max 4k bytes at a time" -- Use max of 4k instead of 2k, limiting to single pages - "s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time" -- Limit to single pages - "s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode" -- Added - "s390x/tcg: MVCS/MVCP: Properly wrap the length" -- Properly use 32 instead of 31 bit. - "s390x/tcg: MVST: Fix storing back the addresses to registers" -- Read R0 implicitly - "s390x/tcg: Fault-safe memset" -- Speed up TLB_NOTDIRTY handling -- Move single-page access to helper function -- Pass access structure to access_memset() -- Replace access_prepare() by previous access_prepare_idx() - "s390x/tcg: Fault-safe memmove" -- Pass access structure to access_memmove() -- Speed up TLB_NOTDIRTY handling when accessing single bytes - The other fault-safe handling patches were adapted to work with the changed access functions. mmu_idx is now always passed to access_prepare() from the helpers. v1 -> v2: - Include many fixes - Fix more instructions - Use the new probe_access() function - Include "tests/tcg: target/s390x: Test MVO" David Hildenbrand (29): s390x/tcg: Reset exception_index to -1 instead of 0 s390x/tcg: MVCL: Zero out unused bits of address s390x/tcg: MVCL: Detect destructive overlaps s390x/tcg: MVCL: Process max 4k bytes at a time s390x/tcg: MVC: Increment the length once s390x/tcg: MVC: Use is_destructive_overlap() s390x/tcg: MVPG: Check for specification exceptions s390x/tcg: MVPG: Properly wrap the addresses s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time s390x/tcg: MVCS/MVCP: Check for special operation exceptions s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode s390x/tcg: MVCS/MVCP: Properly wrap the length s390x/tcg: MVST: Check for specification exceptions s390x/tcg: MVST: Fix storing back the addresses to registers s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY s390x/tcg: Fault-safe memset s390x/tcg: Fault-safe memmove s390x/tcg: MVCS/MVCP: Use access_memmove() s390x/tcg: MVC: Fault-safe handling on destructive overlaps s390x/tcg: MVCLU: Fault-safe handling s390x/tcg: OC: Fault-safe handling s390x/tcg: XC: Fault-safe handling s390x/tcg: NC: Fault-safe handling s390x/tcg: MVCIN: Fault-safe handling s390x/tcg: MVN: Fault-safe handling s390x/tcg: MVZ: Fault-safe handling s390x/tcg: MVST: Fault-safe handling s390x/tcg: MVO: Fault-safe handling tests/tcg: target/s390x: Test MVO target/s390x/cpu.h | 4 + target/s390x/helper.h | 2 +- target/s390x/insn-data.def | 2 +- target/s390x/mem_helper.c | 743 ++++++++++++++++++++++---------- target/s390x/translate.c | 12 +- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/mvo.c | 25 ++ 7 files changed, 564 insertions(+), 225 deletions(-) create mode 100644 tests/tcg/s390x/mvo.c --=20 2.21.0