From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Garima Singh via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Garima Singh <garima.singh@microsoft.com>,
Derrick Stolee <stolee@gmail.com>
Subject: Re: [PATCH v2 1/1] commit-graph: add --[no-]progress to write and verify.
Date: Tue, 17 Sep 2019 00:36:07 +0200 [thread overview]
Message-ID: <20190916223607.GE6190@szeder.dev> (raw)
In-Reply-To: <47cc99bd151db67fe2ee0f91bb98b3eb7e55786d.1566836997.git.gitgitgadget@gmail.com>
On Mon, Aug 26, 2019 at 09:29:58AM -0700, Garima Singh via GitGitGadget wrote:
> From: Garima Singh <garima.singh@microsoft.com>
>
> Add --[no-]progress to git commit-graph write and verify.
> The progress feature was introduced in 7b0f229
> ("commit-graph write: add progress output", 2018-09-17) but
> the ability to opt-out was overlooked.
> diff --git a/t/t5324-split-commit-graph.sh b/t/t5324-split-commit-graph.sh
> index 99f4ef4c19..4fc3fda9d6 100755
> --- a/t/t5324-split-commit-graph.sh
> +++ b/t/t5324-split-commit-graph.sh
> @@ -319,7 +319,7 @@ test_expect_success 'add octopus merge' '
> git merge commits/3 commits/4 &&
> git branch merge/octopus &&
> git commit-graph write --reachable --split &&
> - git commit-graph verify 2>err &&
> + git commit-graph verify --progress 2>err &&
Why is it necessary to use '--progress' here? It should not be
necessary, because the commit message doesn't mention that it changed
the default behavior of 'git commit-graph verify'...
> test_line_count = 3 err &&
Having said that, this test should not check the number of progress
lines in the first place; see the recent discussion:
https://public-inbox.org/git/ec14865f-98cb-5e1a-b580-8b6fddaa6217@gmail.com/
> test_i18ngrep ! warning err &&
> test_line_count = 3 $graphdir/commit-graph-chain
> --
> gitgitgadget
next prev parent reply other threads:[~2019-09-16 22:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 18:37 [PATCH 0/1] commit-graph: add --[no-]progress to write and verify Garima Singh via GitGitGadget
2019-08-20 18:37 ` [PATCH 1/1] " Garima Singh via GitGitGadget
2019-08-20 21:11 ` Junio C Hamano
2019-08-20 21:13 ` Eric Sunshine
2019-08-21 16:47 ` Junio C Hamano
2019-08-20 18:45 ` [PATCH 0/1] " Derrick Stolee
2019-08-26 16:29 ` [PATCH v2 " Garima Singh via GitGitGadget
2019-08-26 16:29 ` [PATCH v2 1/1] " Garima Singh via GitGitGadget
2019-09-12 20:40 ` Junio C Hamano
2019-09-16 22:36 ` SZEDER Gábor [this message]
2019-09-17 10:47 ` Derrick Stolee
2019-09-17 12:22 ` SZEDER Gábor
2019-09-10 14:00 ` [PATCH v2 0/1] " Garima Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916223607.GE6190@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=garima.singh@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.