From: Matthias Kaehlcke <mka@chromium.org>
To: Chandana Kishori Chiluveru <cchiluve@codeaurora.org>
Cc: balbi@kernel.org, agross@kernel.org, david.brown@linaro.org,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V2 3/3] arm64: dts: sdm845: Add interconnect properties for USB
Date: Mon, 16 Sep 2019 15:56:08 -0700 [thread overview]
Message-ID: <20190916225608.GH133864@google.com> (raw)
In-Reply-To: <1568634061-14455-4-git-send-email-cchiluve@codeaurora.org>
Hi Chandana.
On Mon, Sep 16, 2019 at 05:11:01PM +0530, Chandana Kishori Chiluveru wrote:
> Populate USB DT node with interconnect properties.
nit: nodes
> Signed-off-by: Chandana Kishori Chiluveru <cchiluve@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index fcb9330..1c41922 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -1837,6 +1837,12 @@
>
> resets = <&gcc GCC_USB30_PRIM_BCR>;
>
> + interconnects = <&rsc_hlos MASTER_USB3_0
> + &rsc_hlos SLAVE_EBI1>,
nit: align second line after '<' for better readability (like
'interrupts' or 'clocks' properties):
interconnects = <&rsc_hlos MASTER_USB3_0
&rsc_hlos SLAVE_EBI1>,
same for the other entries.
> + <&rsc_hlos MASTER_APPSS_PROC
> + &rsc_hlos SLAVE_USB3_0>;
> + interconnect-names = "usb-ddr", "apps-usb";
> +
> usb_1_dwc3: dwc3@a600000 {
> compatible = "snps,dwc3";
> reg = <0 0x0a600000 0 0xcd00>;
> @@ -1881,6 +1887,12 @@
>
> resets = <&gcc GCC_USB30_SEC_BCR>;
>
> + interconnects = <&rsc_hlos MASTER_USB3_1
> + &rsc_hlos SLAVE_EBI1>,
> + <&rsc_hlos MASTER_APPSS_PROC
> + &rsc_hlos SLAVE_USB3_1>;
> + interconnect-names = "usb-ddr", "apps-usb";
> +
> usb_2_dwc3: dwc3@a800000 {
> compatible = "snps,dwc3";
> reg = <0 0x0a800000 0 0xcd00>;
Besides the nits:
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
next prev parent reply other threads:[~2019-09-16 22:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 11:40 [PATCH V2 0/3] ADD interconnect support for USB Chandana Kishori Chiluveru
2019-09-16 11:40 ` [PATCH V2 1/3] dt-bindings: Introduce interconnect bindings for usb Chandana Kishori Chiluveru
2019-09-16 11:41 ` [PATCH V2 2/3] usb: dwc3: qcom: Add interconnect support in dwc3 driver Chandana Kishori Chiluveru
2019-09-16 22:24 ` Matthias Kaehlcke
2019-09-17 11:09 ` cchiluve
2019-09-17 17:58 ` Matthias Kaehlcke
2019-09-16 11:41 ` [PATCH V2 3/3] arm64: dts: sdm845: Add interconnect properties for USB Chandana Kishori Chiluveru
2019-09-16 22:56 ` Matthias Kaehlcke [this message]
2019-09-17 3:54 ` [PATCH V2 0/3] ADD interconnect support " Manu Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916225608.GH133864@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=cchiluve@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.