All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
	linux-kernel@vger.kernel.org,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	vkoul@kernel.org, broonie@kernel.org,
	srinivas.kandagatla@linaro.org, jank@cadence.com,
	slawomir.blauciak@intel.com,
	Sanyog Kale <sanyog.r.kale@intel.com>,
	Bard liao <yung-chuan.liao@linux.intel.com>,
	Rander Wang <rander.wang@linux.intel.com>
Subject: Re: [alsa-devel] [RFC PATCH 8/9] soundwire: intel: remove platform devices and provide new interface
Date: Tue, 17 Sep 2019 07:55:12 +0200	[thread overview]
Message-ID: <20190917055512.GE2058532@kroah.com> (raw)
In-Reply-To: <20190916212342.12578-9-pierre-louis.bossart@linux.intel.com>

On Mon, Sep 16, 2019 at 04:23:41PM -0500, Pierre-Louis Bossart wrote:
> +/**
> + * sdw_intel_probe() - SoundWire Intel probe routine
> + * @parent_handle: ACPI parent handle
> + * @res: resource data
> + *
> + * This creates SoundWire Master and Slave devices below the controller.
> + * All the information necessary is stored in the context, and the res
> + * argument pointer can be freed after this step.
> + */
> +struct sdw_intel_ctx
> +*sdw_intel_probe(struct sdw_intel_res *res)
> +{
> +	return sdw_intel_probe_controller(res);
> +}
> +EXPORT_SYMBOL(sdw_intel_probe);
> +
> +/**
> + * sdw_intel_startup() - SoundWire Intel startup
> + * @ctx: SoundWire context allocated in the probe
> + *
> + */
> +int sdw_intel_startup(struct sdw_intel_ctx *ctx)
> +{
> +	return sdw_intel_startup_controller(ctx);
> +}
> +EXPORT_SYMBOL(sdw_intel_startup);

Why are you exporting these functions if no one calls them?

thanks,

greg k-h
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	tiwai@suse.de, broonie@kernel.org, vkoul@kernel.org,
	jank@cadence.com, srinivas.kandagatla@linaro.org,
	slawomir.blauciak@intel.com,
	Bard liao <yung-chuan.liao@linux.intel.com>,
	Rander Wang <rander.wang@linux.intel.com>,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	Sanyog Kale <sanyog.r.kale@intel.com>
Subject: Re: [RFC PATCH 8/9] soundwire: intel: remove platform devices and provide new interface
Date: Tue, 17 Sep 2019 07:55:12 +0200	[thread overview]
Message-ID: <20190917055512.GE2058532@kroah.com> (raw)
In-Reply-To: <20190916212342.12578-9-pierre-louis.bossart@linux.intel.com>

On Mon, Sep 16, 2019 at 04:23:41PM -0500, Pierre-Louis Bossart wrote:
> +/**
> + * sdw_intel_probe() - SoundWire Intel probe routine
> + * @parent_handle: ACPI parent handle
> + * @res: resource data
> + *
> + * This creates SoundWire Master and Slave devices below the controller.
> + * All the information necessary is stored in the context, and the res
> + * argument pointer can be freed after this step.
> + */
> +struct sdw_intel_ctx
> +*sdw_intel_probe(struct sdw_intel_res *res)
> +{
> +	return sdw_intel_probe_controller(res);
> +}
> +EXPORT_SYMBOL(sdw_intel_probe);
> +
> +/**
> + * sdw_intel_startup() - SoundWire Intel startup
> + * @ctx: SoundWire context allocated in the probe
> + *
> + */
> +int sdw_intel_startup(struct sdw_intel_ctx *ctx)
> +{
> +	return sdw_intel_startup_controller(ctx);
> +}
> +EXPORT_SYMBOL(sdw_intel_startup);

Why are you exporting these functions if no one calls them?

thanks,

greg k-h

  reply	other threads:[~2019-09-17  5:56 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-16 21:23 [alsa-devel] [RFC PATCH 0/9] soundwire: add Master device support, GreyBus style Pierre-Louis Bossart
2019-09-16 21:23 ` Pierre-Louis Bossart
2019-09-16 21:23 ` [alsa-devel] [RFC PATCH 1/9] soundwire: renames to prepare support for master drivers/devices Pierre-Louis Bossart
2019-09-16 21:23   ` Pierre-Louis Bossart
2019-09-16 21:23 ` [alsa-devel] [RFC PATCH 2/9] soundwire: rename dev_to_sdw_dev macro Pierre-Louis Bossart
2019-09-16 21:23   ` Pierre-Louis Bossart
2019-09-16 21:23 ` [alsa-devel] [RFC PATCH 3/9] soundwire: rename drv_to_sdw_slave_driver macro Pierre-Louis Bossart
2019-09-16 21:23   ` Pierre-Louis Bossart
2019-09-16 21:23 ` [alsa-devel] [RFC PATCH 4/9] soundwire: bus_type: rename sdw_drv_ to sdw_slave_drv Pierre-Louis Bossart
2019-09-16 21:23   ` Pierre-Louis Bossart
2019-09-16 21:23 ` [alsa-devel] [RFC PATCH 5/9] soundwire: intel: rename res field as link_res Pierre-Louis Bossart
2019-09-16 21:23   ` Pierre-Louis Bossart
2019-09-16 21:23 ` [alsa-devel] [RFC PATCH 6/9] soundwire: add support for sdw_slave_type Pierre-Louis Bossart
2019-09-16 21:23   ` Pierre-Louis Bossart
2019-09-16 21:23 ` [alsa-devel] [RFC PATCH 7/9] soundwire: add initial definitions for sdw_master_device Pierre-Louis Bossart
2019-09-16 21:23   ` Pierre-Louis Bossart
2019-09-16 21:23 ` [alsa-devel] [RFC PATCH 8/9] soundwire: intel: remove platform devices and provide new interface Pierre-Louis Bossart
2019-09-16 21:23   ` Pierre-Louis Bossart
2019-09-17  5:55   ` Greg KH [this message]
2019-09-17  5:55     ` Greg KH
2019-09-17 14:29     ` [alsa-devel] " Pierre-Louis Bossart
2019-09-17 14:29       ` Pierre-Louis Bossart
2019-09-18 12:06       ` Greg KH
2019-09-18 12:06         ` Greg KH
2019-09-18 13:48         ` Pierre-Louis Bossart
2019-09-18 13:48           ` Pierre-Louis Bossart
2019-09-18 13:53           ` Greg KH
2019-09-18 13:53             ` Greg KH
2019-09-18 13:54             ` Greg KH
2019-09-18 13:54               ` Greg KH
2019-09-18 15:14               ` Pierre-Louis Bossart
2019-09-18 15:14                 ` Pierre-Louis Bossart
2019-09-18 19:50                 ` Greg KH
2019-09-18 19:50                   ` Greg KH
2019-09-16 21:23 ` [alsa-devel] [RFC PATCH 9/9] soundwire: add device driver to sdw_md_driver Pierre-Louis Bossart
2019-09-16 21:23   ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190917055512.GE2058532@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jank@cadence.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=rander.wang@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=sanyog.r.kale@intel.com \
    --cc=slawomir.blauciak@intel.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.de \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.