All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 09/14] dfu: add callback for flush and initiated operation
Date: Tue, 17 Sep 2019 12:44:56 +0200	[thread overview]
Message-ID: <20190917124456.7eb1be1b@jawa> (raw)
In-Reply-To: <20190913141930.15784-10-patrick.delaunay@st.com>

Hi Patrick,

> Add weak callback to allow board specific behavior
> - flush
> - initiated
> 
> This patch prepare usage of DFU back end for communication with
> STM32CubeProgrammer on stm32mp1 platform with stm32prog command.

As I've said previously - please add this use case and info to
./doc/README.dtu.

> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> 
>  drivers/dfu/dfu.c | 19 +++++++++++++++++++
>  include/dfu.h     |  2 ++
>  2 files changed, 21 insertions(+)
> 
> diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c
> index 2697235c24..f12c5afc66 100644
> --- a/drivers/dfu/dfu.c
> +++ b/drivers/dfu/dfu.c
> @@ -22,6 +22,22 @@ static int dfu_alt_num;
>  static int alt_num_cnt;
>  static struct hash_algo *dfu_hash_algo;
>  
> +/*
> + * The purpose of the dfu_flush_callback() function is to
> + * provide callback for dfu user
> + */
> +__weak void dfu_flush_callback(struct dfu_entity *dfu)
> +{
> +}
> +
> +/*
> + * The purpose of the dfu_flush_callback() function is to
> + * provide callback for dfu user

Please update this repeated comment.

> + */
> +__weak void dfu_initiated_callback(struct dfu_entity *dfu)
> +{
> +}
> +
>  /*
>   * The purpose of the dfu_usb_get_reset() function is to
>   * provide information if after USB_DETACH request
> @@ -263,6 +279,7 @@ int dfu_transaction_initiate(struct dfu_entity
> *dfu, bool read) }
>  
>  	dfu->inited = 1;
> +	dfu_initiated_callback(dfu);
>  
>  	return 0;
>  }
> @@ -282,6 +299,8 @@ int dfu_flush(struct dfu_entity *dfu, void *buf,
> int size, int blk_seq_num) printf("\nDFU complete %s: 0x%08x\n",
> dfu_hash_algo->name, dfu->crc);
>  
> +	dfu_flush_callback(dfu);
> +
>  	dfu_transaction_cleanup(dfu);
>  
>  	return ret;
> diff --git a/include/dfu.h b/include/dfu.h
> index 4de7d35914..5d85cc35ef 100644
> --- a/include/dfu.h
> +++ b/include/dfu.h
> @@ -182,6 +182,8 @@ bool dfu_usb_get_reset(void);
>  int dfu_read(struct dfu_entity *de, void *buf, int size, int
> blk_seq_num); int dfu_write(struct dfu_entity *de, void *buf, int
> size, int blk_seq_num); int dfu_flush(struct dfu_entity *de, void
> *buf, int size, int blk_seq_num); +void dfu_flush_callback(struct
> dfu_entity *dfu); +void dfu_initiated_callback(struct dfu_entity
> *dfu); 
>  /*
>   * dfu_defer_flush - pointer to store dfu_entity for deferred
> flashing.



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190917/70f8901c/attachment.sig>

  reply	other threads:[~2019-09-17 10:44 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-13 14:19 [U-Boot] [PATCH 01/14] dfu: cosmetic: cleanup sf to avoid checkpatch error Patrick Delaunay
2019-09-13 14:19 ` [U-Boot] [PATCH 02/14] dfu: sf: add partition support for nor backend Patrick Delaunay
2019-09-16 22:12   ` Lukasz Majewski
2019-09-13 14:19 ` [U-Boot] [PATCH 03/14] dfu: prepare the support of multiple interface Patrick Delaunay
2019-09-13 14:19 ` [U-Boot] [PATCH 04/14] dfu: allow to manage DFU on several devices Patrick Delaunay
2019-09-17 10:25   ` Lukasz Majewski
2019-09-17 11:28     ` Patrick DELAUNAY
2019-09-13 14:19 ` [U-Boot] [PATCH 05/14] dfu: allow read with 0 data for EOF indication Patrick Delaunay
2019-09-17 10:28   ` Lukasz Majewski
2019-09-18 11:45     ` Patrick DELAUNAY
2019-09-13 14:19 ` [U-Boot] [PATCH 06/14] dfu: add backend for MTD device Patrick Delaunay
2019-09-17 10:35   ` Lukasz Majewski
2019-09-17 11:40     ` Patrick DELAUNAY
2019-09-13 14:19 ` [U-Boot] [PATCH 07/14] dfu: add partition support for MTD backend Patrick Delaunay
2019-09-17 10:38   ` Lukasz Majewski
2019-09-17 12:03     ` Patrick DELAUNAY
2019-09-13 14:19 ` [U-Boot] [PATCH 08/14] dfu: add DFU virtual backend Patrick Delaunay
2019-09-17 10:42   ` Lukasz Majewski
2019-09-13 14:19 ` [U-Boot] [PATCH 09/14] dfu: add callback for flush and initiated operation Patrick Delaunay
2019-09-17 10:44   ` Lukasz Majewski [this message]
2019-09-17 12:52     ` Patrick DELAUNAY
2019-09-13 14:19 ` [U-Boot] [PATCH 10/14] stm32mp1: activate DFU support and command MTD Patrick Delaunay
2019-09-13 14:19 ` [U-Boot] [PATCH 11/14] stm32mp1: activate SET_DFU_ALT_INFO Patrick Delaunay
2019-09-13 14:19 ` [U-Boot] [PATCH 12/14] stp32mp1: configs: activate CONFIG_MTD_SPI_NAND Patrick Delaunay
2019-09-13 14:19 ` [U-Boot] [PATCH 13/14] stm32mp1: board: add spi nand support Patrick Delaunay
2019-09-13 14:19 ` [U-Boot] [PATCH 14/14] stm32mp1: add support for virtual partition read Patrick Delaunay
2019-09-16 21:49 ` [U-Boot] [PATCH 01/14] dfu: cosmetic: cleanup sf to avoid checkpatch error Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190917124456.7eb1be1b@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.