From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: sti: fix W=1 warnings Date: Tue, 17 Sep 2019 14:46:35 +0200 Message-ID: <20190917124635.GP3958@phenom.ffwll.local> References: <20190909101254.24191-1-benjamin.gaignard@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1A3626EC36 for ; Tue, 17 Sep 2019 12:46:40 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id p10so1391474edq.1 for ; Tue, 17 Sep 2019 05:46:40 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Benjamin Gaignard , Dave Airlie , Maarten Lankhorst , Sean Paul , Maxime Ripard Cc: David Airlie , ML dri-devel , Benjamin Gaignard , Linux Kernel Mailing List List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBTZXAgMTYsIDIwMTkgYXQgMDM6MTY6NDlQTSArMDIwMCwgQmVuamFtaW4gR2FpZ25h cmQgd3JvdGU6Cj4gTGUgbHVuLiA5IHNlcHQuIDIwMTkgw6AgMTI6MjksIEJlbmphbWluIEdhaWdu YXJkCj4gPGJlbmphbWluLmdhaWduYXJkQHN0LmNvbT4gYSDDqWNyaXQgOgo+ID4KPiA+IEZpeCB3 YXJuaW5ncyB3aGVuIFc9MS4KPiA+IE5vIGNvZGUgY2hhbmdlcywgb25seSBjbGVhbiB1cCBpbiBz dGkgaW50ZXJuYWwgc3RydWN0dXJlcyBhbmQgZnVuY3Rpb25zCj4gPiBkZXNjcmlwdGlvbnMuCj4g Pgo+ID4gU2lnbmVkLW9mZi1ieTogQmVuamFtaW4gR2FpZ25hcmQgPGJlbmphbWluLmdhaWduYXJk QHN0LmNvbT4KPiAKPiBGb3IgbXkgb3duIHJlZmVyZW5jZSwgYXBwbGllZCBvbiBkcm0tbWlzYy1u ZXh0CgpEdWRlIHNlcmlvdXNseSBubzoKClNpZ25lZC1vZmYtYnk6IEJlbmphbWluIEdhaWduYXJk IDxiZW5qYW1pbi5nYWlnbmFyZEBzdC5jb20+ClJldmlld2VkLWJ5OiBCZW5qYW1pbiBHYWlnbmFy ZCA8YmVuamFtaW4uZ2FpZ25hcmRAc3QuY29tPgpTaWduZWQtb2ZmLWJ5OiBCZW5qYW1pbiBHYWln bmFyZCA8YmVuamFtaW4uZ2FpZ25hcmRAbGluYXJvLm9yZz4KTGluazogaHR0cHM6Ly9wYXRjaHdv cmsuZnJlZWRlc2t0b3Aub3JnL3BhdGNoL21zZ2lkLzIwMTkwOTA5MTAxMjU0LjI0MTkxLTEtYmVu amFtaW4uZ2FpZ25hcmRAc3QuY29tCgpTZWxmLXJldmlldyBhaW4ndCBvayBpbiBkcm0tbWlzYywg eW91IG5lZWQgc29tZW9uZSB0bwphY2svZG91YmxlLWNoZWNrL2hhdmUgYSBsb29rLiBBbmQgZ2l2 ZW4gdGhhdCB5b3UgaGFkIHRvIGZhYnJpY2F0ZSB5b3VyCnNlbGYtcmV2aWV3IHlvdXJzZWxmIHNv bWVob3cgKHRoZSB0b29scyByZWFsbHkgZG9uJ3QgZG8gdGhhdCBmb3IgeW91KSB0aGlzCmRvZXNu J3QgbG9vayBsaWtlIGFuIGFjY2lkZW50LgoKQWRkaW5nIG90aGVyIG1haW50YWluZXJzLgotRGFu aWVsCgo+IAo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfY3Vyc29yLmMgfCAg MiArLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX2R2by5jICAgIHwgIDIgKy0KPiA+ICBk cml2ZXJzL2dwdS9kcm0vc3RpL3N0aV9nZHAuYyAgICB8ICAyICstCj4gPiAgZHJpdmVycy9ncHUv ZHJtL3N0aS9zdGlfaGRhLmMgICAgfCAgMiArLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9zdGkvc3Rp X2hkbWkuYyAgIHwgIDQgKystLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX3R2b3V0LmMg IHwgMTAgKysrKystLS0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX3Z0Zy5jICAgIHwg IDIgKy0KPiA+ICA3IGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9u cygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV9jdXJzb3Iu YyBiL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX2N1cnNvci5jCj4gPiBpbmRleCAwYmY3YzMzMmNm MGIuLmVhNjRjMWRjYWY2MyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3Rp X2N1cnNvci5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV9jdXJzb3IuYwo+ID4g QEAgLTQ3LDcgKzQ3LDcgQEAgc3RydWN0IGRtYV9waXhtYXAgewo+ID4gICAgICAgICB2b2lkICpi YXNlOwo+ID4gIH07Cj4gPgo+ID4gLS8qKgo+ID4gKy8qCj4gPiAgICogU1RJIEN1cnNvciBzdHJ1 Y3R1cmUKPiA+ICAgKgo+ID4gICAqIEBzdGlfcGxhbmU6ICAgIHN0aV9wbGFuZSBzdHJ1Y3R1cmUK PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV9kdm8uYyBiL2RyaXZlcnMv Z3B1L2RybS9zdGkvc3RpX2R2by5jCj4gPiBpbmRleCA5ZTZkNWQ4YjcwMzAuLmMzM2QwYWFlZTgy YiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX2R2by5jCj4gPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV9kdm8uYwo+ID4gQEAgLTY1LDcgKzY1LDcgQEAgc3Rh dGljIHN0cnVjdCBkdm9fY29uZmlnIHJnYl8yNGJpdF9kZV9jZmcgPSB7Cj4gPiAgICAgICAgIC5h d2dfZndnZW5fZmN0ID0gc3RpX2F3Z19nZW5lcmF0ZV9jb2RlX2RhdGFfZW5hYmxlX21vZGUsCj4g PiAgfTsKPiA+Cj4gPiAtLyoqCj4gPiArLyoKPiA+ICAgKiBTVEkgZGlnaXRhbCB2aWRlbyBvdXRw dXQgc3RydWN0dXJlCj4gPiAgICoKPiA+ICAgKiBAZGV2OiBkcml2ZXIgZGV2aWNlCj4gPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfZ2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0v c3RpL3N0aV9nZHAuYwo+ID4gaW5kZXggOGU5MjZjZDZhMWM4Li4xMTU5NWM3NDg4NDQgMTAwNjQ0 Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV9nZHAuYwo+ID4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL3N0aS9zdGlfZ2RwLmMKPiA+IEBAIC0xMDMsNyArMTAzLDcgQEAgc3RydWN0IHN0 aV9nZHBfbm9kZV9saXN0IHsKPiA+ICAgICAgICAgZG1hX2FkZHJfdCBidG1fZmllbGRfcGFkZHI7 Cj4gPiAgfTsKPiA+Cj4gPiAtLyoqCj4gPiArLyoKPiA+ICAgKiBTVEkgR0RQIHN0cnVjdHVyZQo+ ID4gICAqCj4gPiAgICogQHN0aV9wbGFuZTogICAgICAgICAgc3RpX3BsYW5lIHN0cnVjdHVyZQo+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX2hkYS5jIGIvZHJpdmVycy9n cHUvZHJtL3N0aS9zdGlfaGRhLmMKPiA+IGluZGV4IDk0ZTQwNGYxMzIzNC4uMzUxMmE5NGEwZmNh IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfaGRhLmMKPiA+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX2hkYS5jCj4gPiBAQCAtMjMwLDcgKzIzMCw3IEBAIHN0 YXRpYyBjb25zdCBzdHJ1Y3Qgc3RpX2hkYV92aWRlb19jb25maWcgaGRhX3N1cHBvcnRlZF9tb2Rl c1tdID0gewo+ID4gICAgICAgICAgQVdHaV83MjB4NDgwcF82MCwgTk5fNzIweDQ4MHBfNjAsIFZJ RF9FRH0KPiA+ICB9Owo+ID4KPiA+IC0vKioKPiA+ICsvKgo+ID4gICAqIFNUSSBoZCBhbmFsb2cg c3RydWN0dXJlCj4gPiAgICoKPiA+ICAgKiBAZGV2OiBkcml2ZXIgZGV2aWNlCj4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfaGRtaS5jIGIvZHJpdmVycy9ncHUvZHJtL3N0 aS9zdGlfaGRtaS5jCj4gPiBpbmRleCBmMDNkNjE3ZWRjNGMuLjg3ZTM0ZjdhNmNmZSAxMDA2NDQK PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX2hkbWkuYwo+ID4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL3N0aS9zdGlfaGRtaS5jCj4gPiBAQCAtMzMzLDcgKzMzMyw2IEBAIHN0YXRpYyB2 b2lkIGhkbWlfaW5mb2ZyYW1lX3Jlc2V0KHN0cnVjdCBzdGlfaGRtaSAqaGRtaSwKPiA+ICAgKiBI ZWxwZXIgdG8gY29uY2F0ZW5hdGUgaW5mb2ZyYW1lIGluIDMyIGJpdHMgd29yZAo+ID4gICAqCj4g PiAgICogQHB0cjogcG9pbnRlciBvbiB0aGUgaGRtaSBpbnRlcm5hbCBzdHJ1Y3R1cmUKPiA+IC0g KiBAZGF0YTogaW5mb2ZyYW1lIHRvIHdyaXRlCj4gPiAgICogQHNpemU6IHNpemUgdG8gd3JpdGUK PiA+ICAgKi8KPiA+ICBzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGludCBoZG1pX2luZm9mcmFtZV9z dWJwYWNrKGNvbnN0IHU4ICpwdHIsIHNpemVfdCBzaXplKQo+ID4gQEAgLTU0MywxMyArNTQyLDE0 IEBAIHN0YXRpYyBpbnQgaGRtaV92ZW5kb3JfaW5mb2ZyYW1lX2NvbmZpZyhzdHJ1Y3Qgc3RpX2hk bWkgKmhkbWkpCj4gPiAgICAgICAgIHJldHVybiAwOwo+ID4gIH0KPiA+Cj4gPiArI2RlZmluZSBI RE1JX1RJTUVPVVRfU1dSRVNFVCAgMTAwICAgLyptaWxsaXNlY29uZHMgKi8KPiA+ICsKPiA+ICAv KioKPiA+ICAgKiBTb2Z0d2FyZSByZXNldCBvZiB0aGUgaGRtaSBzdWJzeXN0ZW0KPiA+ICAgKgo+ ID4gICAqIEBoZG1pOiBwb2ludGVyIG9uIHRoZSBoZG1pIGludGVybmFsIHN0cnVjdHVyZQo+ID4g ICAqCj4gPiAgICovCj4gPiAtI2RlZmluZSBIRE1JX1RJTUVPVVRfU1dSRVNFVCAgMTAwICAgLypt aWxsaXNlY29uZHMgKi8KPiA+ICBzdGF0aWMgdm9pZCBoZG1pX3N3cmVzZXQoc3RydWN0IHN0aV9o ZG1pICpoZG1pKQo+ID4gIHsKPiA+ICAgICAgICAgdTMyIHZhbDsKPiA+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vc3RpL3N0aV90dm91dC5jIGIvZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlf dHZvdXQuYwo+ID4gaW5kZXggZTFiM2M4Y2I3Mjg3Li5iMWZjNzdiMTUwZGEgMTAwNjQ0Cj4gPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV90dm91dC5jCj4gPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vc3RpL3N0aV90dm91dC5jCj4gPiBAQCAtMTU3LDkgKzE1Nyw5IEBAIHN0YXRpYyB2b2lk IHR2b3V0X3dyaXRlKHN0cnVjdCBzdGlfdHZvdXQgKnR2b3V0LCB1MzIgdmFsLCBpbnQgb2Zmc2V0 KQo+ID4gICAqCj4gPiAgICogQHR2b3V0OiB0dm91dCBzdHJ1Y3R1cmUKPiA+ICAgKiBAcmVnOiBy ZWdpc3RlciB0byBzZXQKPiA+IC0gKiBAY3JfcjoKPiA+IC0gKiBAeV9nOgo+ID4gLSAqIEBjYl9i Ogo+ID4gKyAqIEBjcl9yOiByZWQgY2hyb21hIG9yIHJlZCBvcmRlcgo+ID4gKyAqIEB5X2c6IHkg b3IgZ3JlZW4gb3JkZXIKPiA+ICsgKiBAY2JfYjogYmx1ZSBjaHJvbWEgb3IgYmx1ZSBvcmRlcgo+ ID4gICAqLwo+ID4gIHN0YXRpYyB2b2lkIHR2b3V0X3ZpcF9zZXRfY29sb3Jfb3JkZXIoc3RydWN0 IHN0aV90dm91dCAqdHZvdXQsIGludCByZWcsCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHUzMiBjcl9yLCB1MzIgeV9nLCB1MzIgY2JfYikKPiA+IEBAIC0yMTQsNyAr MjE0LDcgQEAgc3RhdGljIHZvaWQgdHZvdXRfdmlwX3NldF9ybmQoc3RydWN0IHN0aV90dm91dCAq dHZvdXQsIGludCByZWcsIHUzMiBybmQpCj4gPiAgICogQHR2b3V0OiB0dm91dCBzdHJ1Y3R1cmUK PiA+ICAgKiBAcmVnOiByZWdpc3RlciB0byBzZXQKPiA+ICAgKiBAbWFpbl9wYXRoOiBtYWluIG9y IGF1eGlsaWFyeSBwYXRoCj4gPiAtICogQHNlbF9pbnB1dDogc2VsZWN0ZWRfaW5wdXQgKG1haW4v YXV4ICsgY29udikKPiA+ICsgKiBAdmlkZW9fb3V0OiBzZWxlY3RlZF9pbnB1dCAobWFpbi9hdXgg KyBjb252KQo+ID4gICAqLwo+ID4gIHN0YXRpYyB2b2lkIHR2b3V0X3ZpcF9zZXRfc2VsX2lucHV0 KHN0cnVjdCBzdGlfdHZvdXQgKnR2b3V0LAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgaW50IHJlZywKPiA+IEBAIC0yNTEsNyArMjUxLDcgQEAgc3RhdGljIHZvaWQgdHZv dXRfdmlwX3NldF9zZWxfaW5wdXQoc3RydWN0IHN0aV90dm91dCAqdHZvdXQsCj4gPiAgICoKPiA+ ICAgKiBAdHZvdXQ6IHR2b3V0IHN0cnVjdHVyZQo+ID4gICAqIEByZWc6IHJlZ2lzdGVyIHRvIHNl dAo+ID4gLSAqIEBpbl92aWRfc2lnbmVkOiB1c2VkIHZpZGVvIGlucHV0IGZvcm1hdAo+ID4gKyAq IEBpbl92aWRfZm10OiB1c2VkIHZpZGVvIGlucHV0IGZvcm1hdAo+ID4gICAqLwo+ID4gIHN0YXRp YyB2b2lkIHR2b3V0X3ZpcF9zZXRfaW5fdmlkX2ZtdChzdHJ1Y3Qgc3RpX3R2b3V0ICp0dm91dCwK PiA+ICAgICAgICAgICAgICAgICBpbnQgcmVnLCB1MzIgaW5fdmlkX2ZtdCkKPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV92dGcuYyBiL2RyaXZlcnMvZ3B1L2RybS9zdGkv c3RpX3Z0Zy5jCj4gPiBpbmRleCBlZjQwMDlmMTEzOTYuLjBiMTdhYzhhM2ZhYSAxMDA2NDQKPiA+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX3Z0Zy5jCj4gPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vc3RpL3N0aV92dGcuYwo+ID4gQEAgLTEyMSw3ICsxMjEsNyBAQCBzdHJ1Y3Qgc3RpX3Z0 Z19zeW5jX3BhcmFtcyB7Cj4gPiAgICAgICAgIHUzMiB2c3luY19vZmZfYm90Owo+ID4gIH07Cj4g Pgo+ID4gLS8qKgo+ID4gKy8qCj4gPiAgICogU1RJIFZURyBzdHJ1Y3R1cmUKPiA+ICAgKgo+ID4g ICAqIEByZWdzOiByZWdpc3RlciBtYXBwaW5nCj4gPiAtLQo+ID4gMi4xNS4wCj4gPgoKLS0gCkRh bmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9i bG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 953E3C4CECD for ; Tue, 17 Sep 2019 12:46:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E000206C2 for ; Tue, 17 Sep 2019 12:46:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="j7cs36nX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728079AbfIQMql (ORCPT ); Tue, 17 Sep 2019 08:46:41 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:32858 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725901AbfIQMql (ORCPT ); Tue, 17 Sep 2019 08:46:41 -0400 Received: by mail-ed1-f66.google.com with SMTP id c4so3237014edl.0 for ; Tue, 17 Sep 2019 05:46:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=MWc4ebZf4LWit2V6qbngzDl/b8CZm1E51lckC0limas=; b=j7cs36nX9popbpxWwyXWezsi1VQOvcdeufG9Gax/aEuCl2h+LWBFWnpqlNsCEyp8m/ A29uy8V1qrc2BQWKnM4IeAXO2ZT67kvhp8LA7V9dzSBT2kYlZzDTEisjH/TJBHCzmhgX AzjlWqyz6Wh/UTiuVV7YlLvlnznLU2Q8Q8OYc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=MWc4ebZf4LWit2V6qbngzDl/b8CZm1E51lckC0limas=; b=ROR0HnYWmO+QtV1MSg2HIVe3bJLE03NxICDBgfKjK7EsUvoWddvXbjxAgHcAdGnedj jJNMLE+9gRY5iZUG37qihUs1MbqLyvX1Ch6BlGSjMpqfEJtrNYCTkq9ABvUysuuoZxzA fAsQPoItnpXlbj+Yq1OvMTSxB36e2IEptFb/avyMJgnFicRAzN82C8T4Gt97KZbdwRiP az+ZVnnO0xW/rLe3jXp1Ba9eX+L8TaH/dDJ1Sy3/fIRUagQeuxfMEK2Es0bnGll7tAMH 0CSomjR7vJ7k0MGanmkuVQWURJiML+T4pRA8kho4xcdrsppQwGMZC7XKnD1Zgg9fKeHI /gQA== X-Gm-Message-State: APjAAAU072X64LndmG5+HBpJPP5qM6nsKLmYpNJFEI0BLRMludknK095 UvDLweWtcSrwwutT+Do46o9SBw== X-Google-Smtp-Source: APXvYqy5zuFU9N4CokRUmdSL+8Eyd/hIZQcHTwX6zn4AHO8aIWpBlh6L2q45xnPUISOdxW8QkYGnIA== X-Received: by 2002:aa7:cdd6:: with SMTP id h22mr2526239edw.132.1568724398667; Tue, 17 Sep 2019 05:46:38 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id e20sm264593eja.75.2019.09.17.05.46.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2019 05:46:37 -0700 (PDT) Date: Tue, 17 Sep 2019 14:46:35 +0200 From: Daniel Vetter To: Benjamin Gaignard , Dave Airlie , Maarten Lankhorst , Sean Paul , Maxime Ripard Cc: Benjamin Gaignard , David Airlie , Daniel Vetter , ML dri-devel , Linux Kernel Mailing List Subject: Re: [PATCH] drm: sti: fix W=1 warnings Message-ID: <20190917124635.GP3958@phenom.ffwll.local> Mail-Followup-To: Benjamin Gaignard , Dave Airlie , Maarten Lankhorst , Sean Paul , Maxime Ripard , Benjamin Gaignard , David Airlie , ML dri-devel , Linux Kernel Mailing List References: <20190909101254.24191-1-benjamin.gaignard@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: Linux phenom 5.2.0-2-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 16, 2019 at 03:16:49PM +0200, Benjamin Gaignard wrote: > Le lun. 9 sept. 2019 à 12:29, Benjamin Gaignard > a écrit : > > > > Fix warnings when W=1. > > No code changes, only clean up in sti internal structures and functions > > descriptions. > > > > Signed-off-by: Benjamin Gaignard > > For my own reference, applied on drm-misc-next Dude seriously no: Signed-off-by: Benjamin Gaignard Reviewed-by: Benjamin Gaignard Signed-off-by: Benjamin Gaignard Link: https://patchwork.freedesktop.org/patch/msgid/20190909101254.24191-1-benjamin.gaignard@st.com Self-review ain't ok in drm-misc, you need someone to ack/double-check/have a look. And given that you had to fabricate your self-review yourself somehow (the tools really don't do that for you) this doesn't look like an accident. Adding other maintainers. -Daniel > > > --- > > drivers/gpu/drm/sti/sti_cursor.c | 2 +- > > drivers/gpu/drm/sti/sti_dvo.c | 2 +- > > drivers/gpu/drm/sti/sti_gdp.c | 2 +- > > drivers/gpu/drm/sti/sti_hda.c | 2 +- > > drivers/gpu/drm/sti/sti_hdmi.c | 4 ++-- > > drivers/gpu/drm/sti/sti_tvout.c | 10 +++++----- > > drivers/gpu/drm/sti/sti_vtg.c | 2 +- > > 7 files changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/gpu/drm/sti/sti_cursor.c b/drivers/gpu/drm/sti/sti_cursor.c > > index 0bf7c332cf0b..ea64c1dcaf63 100644 > > --- a/drivers/gpu/drm/sti/sti_cursor.c > > +++ b/drivers/gpu/drm/sti/sti_cursor.c > > @@ -47,7 +47,7 @@ struct dma_pixmap { > > void *base; > > }; > > > > -/** > > +/* > > * STI Cursor structure > > * > > * @sti_plane: sti_plane structure > > diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c > > index 9e6d5d8b7030..c33d0aaee82b 100644 > > --- a/drivers/gpu/drm/sti/sti_dvo.c > > +++ b/drivers/gpu/drm/sti/sti_dvo.c > > @@ -65,7 +65,7 @@ static struct dvo_config rgb_24bit_de_cfg = { > > .awg_fwgen_fct = sti_awg_generate_code_data_enable_mode, > > }; > > > > -/** > > +/* > > * STI digital video output structure > > * > > * @dev: driver device > > diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c > > index 8e926cd6a1c8..11595c748844 100644 > > --- a/drivers/gpu/drm/sti/sti_gdp.c > > +++ b/drivers/gpu/drm/sti/sti_gdp.c > > @@ -103,7 +103,7 @@ struct sti_gdp_node_list { > > dma_addr_t btm_field_paddr; > > }; > > > > -/** > > +/* > > * STI GDP structure > > * > > * @sti_plane: sti_plane structure > > diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c > > index 94e404f13234..3512a94a0fca 100644 > > --- a/drivers/gpu/drm/sti/sti_hda.c > > +++ b/drivers/gpu/drm/sti/sti_hda.c > > @@ -230,7 +230,7 @@ static const struct sti_hda_video_config hda_supported_modes[] = { > > AWGi_720x480p_60, NN_720x480p_60, VID_ED} > > }; > > > > -/** > > +/* > > * STI hd analog structure > > * > > * @dev: driver device > > diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c > > index f03d617edc4c..87e34f7a6cfe 100644 > > --- a/drivers/gpu/drm/sti/sti_hdmi.c > > +++ b/drivers/gpu/drm/sti/sti_hdmi.c > > @@ -333,7 +333,6 @@ static void hdmi_infoframe_reset(struct sti_hdmi *hdmi, > > * Helper to concatenate infoframe in 32 bits word > > * > > * @ptr: pointer on the hdmi internal structure > > - * @data: infoframe to write > > * @size: size to write > > */ > > static inline unsigned int hdmi_infoframe_subpack(const u8 *ptr, size_t size) > > @@ -543,13 +542,14 @@ static int hdmi_vendor_infoframe_config(struct sti_hdmi *hdmi) > > return 0; > > } > > > > +#define HDMI_TIMEOUT_SWRESET 100 /*milliseconds */ > > + > > /** > > * Software reset of the hdmi subsystem > > * > > * @hdmi: pointer on the hdmi internal structure > > * > > */ > > -#define HDMI_TIMEOUT_SWRESET 100 /*milliseconds */ > > static void hdmi_swreset(struct sti_hdmi *hdmi) > > { > > u32 val; > > diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c > > index e1b3c8cb7287..b1fc77b150da 100644 > > --- a/drivers/gpu/drm/sti/sti_tvout.c > > +++ b/drivers/gpu/drm/sti/sti_tvout.c > > @@ -157,9 +157,9 @@ static void tvout_write(struct sti_tvout *tvout, u32 val, int offset) > > * > > * @tvout: tvout structure > > * @reg: register to set > > - * @cr_r: > > - * @y_g: > > - * @cb_b: > > + * @cr_r: red chroma or red order > > + * @y_g: y or green order > > + * @cb_b: blue chroma or blue order > > */ > > static void tvout_vip_set_color_order(struct sti_tvout *tvout, int reg, > > u32 cr_r, u32 y_g, u32 cb_b) > > @@ -214,7 +214,7 @@ static void tvout_vip_set_rnd(struct sti_tvout *tvout, int reg, u32 rnd) > > * @tvout: tvout structure > > * @reg: register to set > > * @main_path: main or auxiliary path > > - * @sel_input: selected_input (main/aux + conv) > > + * @video_out: selected_input (main/aux + conv) > > */ > > static void tvout_vip_set_sel_input(struct sti_tvout *tvout, > > int reg, > > @@ -251,7 +251,7 @@ static void tvout_vip_set_sel_input(struct sti_tvout *tvout, > > * > > * @tvout: tvout structure > > * @reg: register to set > > - * @in_vid_signed: used video input format > > + * @in_vid_fmt: used video input format > > */ > > static void tvout_vip_set_in_vid_fmt(struct sti_tvout *tvout, > > int reg, u32 in_vid_fmt) > > diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c > > index ef4009f11396..0b17ac8a3faa 100644 > > --- a/drivers/gpu/drm/sti/sti_vtg.c > > +++ b/drivers/gpu/drm/sti/sti_vtg.c > > @@ -121,7 +121,7 @@ struct sti_vtg_sync_params { > > u32 vsync_off_bot; > > }; > > > > -/** > > +/* > > * STI VTG structure > > * > > * @regs: register mapping > > -- > > 2.15.0 > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch