From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:adf:ef42:0:0:0:0:0 with SMTP id c2csp5116058wrp; Tue, 17 Sep 2019 04:21:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqyOXZ/oi3netDXYORqskhywfro92LnuP9BDAKbt1ILDkIWySBezG8jJD4XKDB3EDnTzOPj/ X-Received: by 2002:a17:906:e10a:: with SMTP id gj10mr4219883ejb.134.1568719299548; Tue, 17 Sep 2019 04:21:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568719299; cv=none; d=google.com; s=arc-20160816; b=PT/2Ia7W++27aOHiWtxvWzvG09NoU3OFOcV3k7z7Tomv8zRzyCo6sS30YXPCmkPoI8 rVQAM+9Wc6EERcw348d9kVABTHX4X0IB8UPCJSLuRJj/7hw3Ehh8ZDlniqdyWuIyhXcO ANWjDqNwLAgA2nesTiDi26SfU4c4Z3Nu6nCMN83cGWt4zwUJn5BMkoemEY7bL1y+Wkiz 6oWryADz1SSLEflGYp9vZNRi/SFGy05IEHneR68UyK0Vg2tEgalCQRTAp7uGoL4DvIYg XeHpBJwMwZeYhL8jylmYjUeji9m/hqCl697qjoxZMULAw9HfijQqmCkIJFCcAtzMWm77 o95Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:to:from:date; bh=NOOiqsOIrK4HvfHKUrqHDbzGgL6JxGma48e2Js6Gp2c=; b=e1z+NNmxP1eiVF1VK31QB8MO7Vpc70CxI+NE1+C+mC+rhWDymBMLq7uEUc+B7IXFiU gxhZ8R7n80giS2yapcn8pAZjlKwlu4EBMmAEvxKFFwP2MJTF+rhpHNQQiZFeqt3cila6 06Goz4V7FbCcJ2D/kpI6p2uOHDoAD+Zwm7lLoWfjVXVGEe89vztgG0BHHdOAsdPD6Osc 6FkRD5h6gghr3WDDVHDdqnXLlgXKf6WN0SK2iKiFu/DLtjhc1iRmJUZfn7iPrN7RK1rB jvv2+haprHqaNh4324zOwoytgkOH4zuMfBpgbSsJaSfkvpnuZfUNXLSml1FYOEv/9wki lFcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g21si1055226edm.116.2019.09.17.04.21.39 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Sep 2019 04:21:39 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:44452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iABYA-00063Q-7e for alex.bennee@linaro.org; Tue, 17 Sep 2019 07:21:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54596) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iABXz-00063E-HE for qemu-arm@nongnu.org; Tue, 17 Sep 2019 07:21:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iABXy-0002xo-0L for qemu-arm@nongnu.org; Tue, 17 Sep 2019 07:21:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38818) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iABXx-0002xK-Ql; Tue, 17 Sep 2019 07:21:25 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5E0DE307D90E; Tue, 17 Sep 2019 11:21:24 +0000 (UTC) Received: from gondolin (dhcp-192-230.str.redhat.com [10.33.192.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id A86F919C4F; Tue, 17 Sep 2019 11:21:04 +0000 (UTC) Date: Tue, 17 Sep 2019 13:21:02 +0200 From: Cornelia Huck To: Greg Kurz Message-ID: <20190917132102.4031e77e.cohuck@redhat.com> In-Reply-To: <156871563702.196432.5964411202152101367.stgit@bahia.lan> References: <156871562997.196432.17776290406203122029.stgit@bahia.lan> <156871563702.196432.5964411202152101367.stgit@bahia.lan> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Tue, 17 Sep 2019 11:21:24 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-arm] [PATCH 01/17] error: Update error_append_hint()'s documentation X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , "Michael S. Tsirkin" , Jeff Cody , Mark Cave-Ayland , qemu-devel@nongnu.org, Michael Roth , Gerd Hoffmann , Subbaraya Sundeep , Eric Blake , qemu-block@nongnu.org, Juan Quintela , David Hildenbrand , Markus Armbruster , Halil Pasic , Christian Borntraeger , Marcel Apfelbaum , =?UTF-8?B?TWFyYy1BbmRy?= =?UTF-8?B?w6k=?= Lureau , David Gibson , Eric Farman , "Dr. David Alan Gilbert" , Yuval Shaia , Alex Williamson , qemu-arm@nongnu.org, John Snow , Richard Henderson , Kevin Wolf , "Daniel P. =?UTF-8?B?QmVycmFuZ8Op?=" , qemu-s390x@nongnu.org, Max Reitz , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: F5P831CQKHGG On Tue, 17 Sep 2019 12:20:37 +0200 Greg Kurz wrote: > error_setg() and error_propagate(), as well as their variants, cause > QEMU to terminate when called with &error_fatal or &error_abort. This > prevents to add hints since error_append_hint() isn't even called in > this case. > > It means that error_append_hint() should only be used with a local > error object, and then propagate this local error to the caller. > > Document this in . > > Signed-off-by: Greg Kurz > --- > include/qapi/error.h | 11 ++++++++++- It's a bit awkward requiring a local object, but better safe than sorry. Reviewed-by: Cornelia Huck From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD3BEC4CECD for ; Tue, 17 Sep 2019 11:22:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8101E21852 for ; Tue, 17 Sep 2019 11:22:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8101E21852 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iABYr-0006gz-M5 for qemu-devel@archiver.kernel.org; Tue, 17 Sep 2019 07:22:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54630) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iABY3-000679-Et for qemu-devel@nongnu.org; Tue, 17 Sep 2019 07:21:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iABY2-00030B-C1 for qemu-devel@nongnu.org; Tue, 17 Sep 2019 07:21:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38818) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iABXx-0002xK-Ql; Tue, 17 Sep 2019 07:21:25 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5E0DE307D90E; Tue, 17 Sep 2019 11:21:24 +0000 (UTC) Received: from gondolin (dhcp-192-230.str.redhat.com [10.33.192.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id A86F919C4F; Tue, 17 Sep 2019 11:21:04 +0000 (UTC) Date: Tue, 17 Sep 2019 13:21:02 +0200 From: Cornelia Huck To: Greg Kurz Message-ID: <20190917132102.4031e77e.cohuck@redhat.com> In-Reply-To: <156871563702.196432.5964411202152101367.stgit@bahia.lan> References: <156871562997.196432.17776290406203122029.stgit@bahia.lan> <156871563702.196432.5964411202152101367.stgit@bahia.lan> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Tue, 17 Sep 2019 11:21:24 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 01/17] error: Update error_append_hint()'s documentation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , "Michael S. Tsirkin" , Jeff Cody , Mark Cave-Ayland , qemu-devel@nongnu.org, Michael Roth , Gerd Hoffmann , Subbaraya Sundeep , qemu-block@nongnu.org, Juan Quintela , David Hildenbrand , Markus Armbruster , Halil Pasic , Christian Borntraeger , =?UTF-8?B?TWFyYy1BbmRy?= =?UTF-8?B?w6k=?= Lureau , David Gibson , Eric Farman , "Dr. David Alan Gilbert" , Yuval Shaia , Alex Williamson , qemu-arm@nongnu.org, John Snow , Richard Henderson , Kevin Wolf , "Daniel P. =?UTF-8?B?QmVycmFuZ8Op?=" , qemu-s390x@nongnu.org, Max Reitz , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 17 Sep 2019 12:20:37 +0200 Greg Kurz wrote: > error_setg() and error_propagate(), as well as their variants, cause > QEMU to terminate when called with &error_fatal or &error_abort. This > prevents to add hints since error_append_hint() isn't even called in > this case. > > It means that error_append_hint() should only be used with a local > error object, and then propagate this local error to the caller. > > Document this in . > > Signed-off-by: Greg Kurz > --- > include/qapi/error.h | 11 ++++++++++- It's a bit awkward requiring a local object, but better safe than sorry. Reviewed-by: Cornelia Huck