From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux admin Subject: Re: [REGRESSION] sdhci no longer detects SD cards on LX2160A Date: Tue, 17 Sep 2019 14:33:17 +0100 Message-ID: <20190917133317.GQ25745@shell.armlinux.org.uk> References: <20190916171509.GG25745@shell.armlinux.org.uk> <20190917081931.GI25745@shell.armlinux.org.uk> <20190917104200.GJ25745@shell.armlinux.org.uk> <20190917111631.GL25745@shell.armlinux.org.uk> <20190917114210.GM25745@shell.armlinux.org.uk> <20190917123326.GN25745@shell.armlinux.org.uk> <20190917130759.GO25745@shell.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Fabio Estevam Cc: dann frazier , linux-mmc , Adrian Hunter , Will Deacon , Nicolin Chen , Christoph Hellwig , Linux ARM List-Id: linux-mmc@vger.kernel.org On Tue, Sep 17, 2019 at 10:24:57AM -0300, Fabio Estevam wrote: > Hi Russell, > > On Tue, Sep 17, 2019 at 10:10 AM Russell King - ARM Linux admin > wrote: > > > Will suggested reverting bd2e75633c80 ("dma-contiguous: use fallback > > alloc_pages for single pages") which has been implicated in the same > > problem here: > > > > https://www.spinics.net/lists/arm-kernel/msg750623.html > > It seems that the final fix was: > https://lore.kernel.org/patchwork/patch/1121600/ > > Does it work for you if we follow the same idea? > > --- a/drivers/mmc/host/sdhci-of-esdhc.c > +++ b/drivers/mmc/host/sdhci-of-esdhc.c > @@ -1105,6 +1105,7 @@ static int sdhci_esdhc_probe(struct platform_device *pdev) > > esdhc_init(pdev, host); > > + sdhci_enable_v4_mode(host); > sdhci_get_of_property(pdev); > > pltfm_host = sdhci_priv(host); That attempts to set bit 12 of the host control register 2 (0x3e). The LX2160A documentation states that bit 28 of 0x3c (they're 32-bit wide registers there) is "reserved". So, you're asking for a documented reserved bit to be set... -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37F09C4CECD for ; Tue, 17 Sep 2019 13:33:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A339206C2 for ; Tue, 17 Sep 2019 13:33:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Cpip1e0T"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="NEuy8P+H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A339206C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v8VfuTbtt/rCch5Ac1/QQ5t2yNgn/7RPWioyTTrYegE=; b=Cpip1e0TyH2VmS 7xTvAnBEEP9PEcfk56SVRc4Oi5glsz7UytRtl60uz6K0X7lyLBzFrSVGc/4MMve7VMoC37PKuCbfY X1ZDgWA+0voXU9n8Ym4t1aYnTG+3Wm23bljXVn4bzEbeQ9lQHN4SSQKcB4kzVmxnA7CcC54xFNZzw 3tBBo+pY8D7JoL+5L7NM3x82mT5XHlucspo2AqWiOQuEoVuF1V6a1dONxM339akLtUDe83uLYLYyx GrLnlhsyzLmfeq4L7c1wEaAFQWrzgaic7NOxlT+3r8cXqkUOeHaUtp0cT1BmhwS5HU6XGCfGy2ZyA QR1Tm5HmK+T7McJkVVjQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iADbp-0003dB-5N; Tue, 17 Sep 2019 13:33:33 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iADbk-0003bP-Kf for linux-arm-kernel@lists.infradead.org; Tue, 17 Sep 2019 13:33:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IaO3Rqk7+O5bRQtudJzKuCkFQ7NvStYQjWVNTuy11ok=; b=NEuy8P+HoAJBIWwI8fCTDHVYQ NPHj58j6BGnSqBZgOtpgXL70qrAN4ppgDLgubXrwKzjECCRLWAKLhTY9vtiow/Sgizb5iidbKV/mK 7Gl477qAJhs96+3d1S10peMEACGtHY8wsLXWbcrEUxcaARirKec1M2/OCgeUIbacRaniNbiAIyv86 6KoJrxOSNmiyac8ugXbnIUAQDjPXfBxHk3Ob8Bw8RUYcR7UJ0OixZbHTgEot+fjFz8IeePnZFiDlD SwpSh+wll6Fh0QTuo7/K8gAKdSQI3qjntcFYao6VmuAJeaWOKi1sXwc7DIi73Syb4XrY/LvxhIQrU H4CGHABHA==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:33130) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iADba-00026a-IB; Tue, 17 Sep 2019 14:33:18 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1iADbZ-0001Js-Ki; Tue, 17 Sep 2019 14:33:17 +0100 Date: Tue, 17 Sep 2019 14:33:17 +0100 From: Russell King - ARM Linux admin To: Fabio Estevam Subject: Re: [REGRESSION] sdhci no longer detects SD cards on LX2160A Message-ID: <20190917133317.GQ25745@shell.armlinux.org.uk> References: <20190916171509.GG25745@shell.armlinux.org.uk> <20190917081931.GI25745@shell.armlinux.org.uk> <20190917104200.GJ25745@shell.armlinux.org.uk> <20190917111631.GL25745@shell.armlinux.org.uk> <20190917114210.GM25745@shell.armlinux.org.uk> <20190917123326.GN25745@shell.armlinux.org.uk> <20190917130759.GO25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190917_063328_686145_8583BF9A X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dann frazier , linux-mmc , Adrian Hunter , Will Deacon , Nicolin Chen , Christoph Hellwig , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 17, 2019 at 10:24:57AM -0300, Fabio Estevam wrote: > Hi Russell, > > On Tue, Sep 17, 2019 at 10:10 AM Russell King - ARM Linux admin > wrote: > > > Will suggested reverting bd2e75633c80 ("dma-contiguous: use fallback > > alloc_pages for single pages") which has been implicated in the same > > problem here: > > > > https://www.spinics.net/lists/arm-kernel/msg750623.html > > It seems that the final fix was: > https://lore.kernel.org/patchwork/patch/1121600/ > > Does it work for you if we follow the same idea? > > --- a/drivers/mmc/host/sdhci-of-esdhc.c > +++ b/drivers/mmc/host/sdhci-of-esdhc.c > @@ -1105,6 +1105,7 @@ static int sdhci_esdhc_probe(struct platform_device *pdev) > > esdhc_init(pdev, host); > > + sdhci_enable_v4_mode(host); > sdhci_get_of_property(pdev); > > pltfm_host = sdhci_priv(host); That attempts to set bit 12 of the host control register 2 (0x3e). The LX2160A documentation states that bit 28 of 0x3c (they're 32-bit wide registers there) is "reserved". So, you're asking for a documented reserved bit to be set... -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel