From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAE51-0000Ay-5r for ath10k@lists.infradead.org; Tue, 17 Sep 2019 14:03:44 +0000 MIME-Version: 1.0 Subject: Re: [PATCH] ath10k: Fix HOST capability QMI incompatibility From: Kalle Valo In-Reply-To: <20190725063108.15790-1-bjorn.andersson@linaro.org> References: <20190725063108.15790-1-bjorn.andersson@linaro.org> Message-Id: <20190917140342.7A30661570@smtp.codeaurora.org> Date: Tue, 17 Sep 2019 14:03:41 +0000 (UTC) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Bjorn Andersson Cc: Mark Rutland , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, Rob Herring , stable@vger.kernel.org, "David S. Miller" Bjorn Andersson wrote: > The introduction of 768ec4c012ac ("ath10k: update HOST capability QMI > message") served the purpose of supporting the new and extended HOST > capability QMI message. > > But while the new message adds a slew of optional members it changes the > data type of the "daemon_support" member, which means that older > versions of the firmware will fail to decode the incoming request > message. > > There is no way to detect this breakage from Linux and there's no way to > recover from sending the wrong message (i.e. we can't just try one > format and then fallback to the other), so a quirk is introduced in > DeviceTree to indicate to the driver that the firmware requires the 8bit > version of this message. > > Cc: stable@vger.kernel.org > Fixes: 768ec4c012ac ("ath10k: update HOST capability qmi message") > Signed-off-by: Bjorn Andersson > Acked-by: Rob Herring > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 7165ef890a4c ath10k: Fix HOST capability QMI incompatibility -- https://patchwork.kernel.org/patch/11058005/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] ath10k: Fix HOST capability QMI incompatibility Date: Tue, 17 Sep 2019 14:03:41 +0000 (UTC) Message-ID: <20190917140342.7A30661570@smtp.codeaurora.org> References: <20190725063108.15790-1-bjorn.andersson@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190725063108.15790-1-bjorn.andersson@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+gldad-ath10k=m.gmane.org@lists.infradead.org To: Bjorn Andersson Cc: Mark Rutland , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, Rob Herring , stable@vger.kernel.org, "David S. Miller" List-Id: devicetree@vger.kernel.org Bjorn Andersson wrote: > The introduction of 768ec4c012ac ("ath10k: update HOST capability QMI > message") served the purpose of supporting the new and extended HOST > capability QMI message. > > But while the new message adds a slew of optional members it changes the > data type of the "daemon_support" member, which means that older > versions of the firmware will fail to decode the incoming request > message. > > There is no way to detect this breakage from Linux and there's no way to > recover from sending the wrong message (i.e. we can't just try one > format and then fallback to the other), so a quirk is introduced in > DeviceTree to indicate to the driver that the firmware requires the 8bit > version of this message. > > Cc: stable@vger.kernel.org > Fixes: 768ec4c012ac ("ath10k: update HOST capability qmi message") > Signed-off-by: Bjorn Andersson > Acked-by: Rob Herring > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 7165ef890a4c ath10k: Fix HOST capability QMI incompatibility -- https://patchwork.kernel.org/patch/11058005/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches