From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43105C4CEC9 for ; Tue, 17 Sep 2019 16:06:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 163D42053B for ; Tue, 17 Sep 2019 16:06:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728718AbfIQQGR (ORCPT ); Tue, 17 Sep 2019 12:06:17 -0400 Received: from foss.arm.com ([217.140.110.172]:58146 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727203AbfIQQGR (ORCPT ); Tue, 17 Sep 2019 12:06:17 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0059E15A2; Tue, 17 Sep 2019 09:06:17 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 181343F575; Tue, 17 Sep 2019 09:06:15 -0700 (PDT) Date: Tue, 17 Sep 2019 17:06:14 +0100 From: Dave Martin To: Cristian Marussi Cc: linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shuah@kernel.org, amit.kachhap@arm.com, andreyknvl@google.com Subject: Re: [PATCH v6 09/11] kselftest: arm64: fake_sigreturn_duplicated_fpsimd Message-ID: <20190917160613.GO27757@arm.com> References: <20190910123111.33478-1-cristian.marussi@arm.com> <20190910123111.33478-10-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190910123111.33478-10-cristian.marussi@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Tue, Sep 10, 2019 at 01:31:09pm +0100, Cristian Marussi wrote: > Add a simple fake_sigreturn testcase which builds a ucontext_t with > an anomalous additional fpsimd_context and place it onto the stack. > Expects a SIGSEGV on test PASS. > > Signed-off-by: Cristian Marussi > --- > v5 --> v6 > - removed unneeded locals > - avoid timeout on failure > v3 --> v4 > - fix commit > - missing include > - using new get_starting_head() helper > - added test description > --- > .../fake_sigreturn_duplicated_fpsimd.c | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c > > diff --git a/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c > new file mode 100644 > index 000000000000..f0cc34dac47c > --- /dev/null > +++ b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c > @@ -0,0 +1,50 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2019 ARM Limited > + * > + * Place a fake sigframe on the stack including an additional FPSIMD > + * record: on sigreturn Kernel must spot this attempt and the test > + * case is expected to be terminated via SEGV. > + */ > + > +#include > +#include > + > +#include "test_signals_utils.h" > +#include "testcases.h" > + > +struct fake_sigframe sf; > + > +static int fake_sigreturn_duplicated_fpsimd_run(struct tdescr *td, > + siginfo_t *si, ucontext_t *uc) > +{ > + struct _aarch64_ctx *shead = GET_SF_RESV_HEAD(sf), *head; > + > + /* just to fill the ucontext_t with something real */ > + if (!get_current_context(td, &sf.uc)) > + return 1; > + > + head = get_starting_head(shead, sizeof(struct fpsimd_context) + HDR_SZ, > + GET_SF_RESV_SIZE(sf), NULL); > + if (!head) > + return 0; > + > + /* Add a spurios fpsimd_context */ Nit: spurious With that, Reviewed-by: Dave Martin [...] Cheers ---Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F4E4C4CEC9 for ; Tue, 17 Sep 2019 16:13:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E6A7021852 for ; Tue, 17 Sep 2019 16:13:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="baq2FtWf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6A7021852 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nk8Zl/Jkc7o29LhffB8pq1PebYpNyGcU6rSES09P5zg=; b=baq2FtWfT+DwyQ 0CW/Cty+hJDGtY1uIppqAv23/vMhHzyoyxuxwGBp56YfvUugudISKrZ1V7RwViazwX+U4s3wG/a3I rp7OR/jAuWHnIlN59zLNl6TVmiftvhUf8zH4RXziJq9ncgrOkk5P7rv5j6nq1iHX1/ZR0s+SbiMN3 YWeifvplDxiz3hnhmwxaZDXWPobDbSYM7E8vJOIPP6cPDsKdL7AI64zoew94H6/4yXLpiF1Jd+MDX Co720tbGvQbeRCl3XZzpxE/mON9HYAunjA/XisUDxkFBFWTULsbIe1Lgh9SxlGM7BWAjb44Ior0Iw et6aIBEQBEjtjS3eNPAg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAG6E-0001lX-ES; Tue, 17 Sep 2019 16:13:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAFzd-0002Lm-Rv for linux-arm-kernel@lists.infradead.org; Tue, 17 Sep 2019 16:06:20 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0059E15A2; Tue, 17 Sep 2019 09:06:17 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 181343F575; Tue, 17 Sep 2019 09:06:15 -0700 (PDT) Date: Tue, 17 Sep 2019 17:06:14 +0100 From: Dave Martin To: Cristian Marussi Subject: Re: [PATCH v6 09/11] kselftest: arm64: fake_sigreturn_duplicated_fpsimd Message-ID: <20190917160613.GO27757@arm.com> References: <20190910123111.33478-1-cristian.marussi@arm.com> <20190910123111.33478-10-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190910123111.33478-10-cristian.marussi@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190917_090618_773958_852FCB80 X-CRM114-Status: GOOD ( 17.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amit.kachhap@arm.com, andreyknvl@google.com, shuah@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 10, 2019 at 01:31:09pm +0100, Cristian Marussi wrote: > Add a simple fake_sigreturn testcase which builds a ucontext_t with > an anomalous additional fpsimd_context and place it onto the stack. > Expects a SIGSEGV on test PASS. > > Signed-off-by: Cristian Marussi > --- > v5 --> v6 > - removed unneeded locals > - avoid timeout on failure > v3 --> v4 > - fix commit > - missing include > - using new get_starting_head() helper > - added test description > --- > .../fake_sigreturn_duplicated_fpsimd.c | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c > > diff --git a/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c > new file mode 100644 > index 000000000000..f0cc34dac47c > --- /dev/null > +++ b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c > @@ -0,0 +1,50 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2019 ARM Limited > + * > + * Place a fake sigframe on the stack including an additional FPSIMD > + * record: on sigreturn Kernel must spot this attempt and the test > + * case is expected to be terminated via SEGV. > + */ > + > +#include > +#include > + > +#include "test_signals_utils.h" > +#include "testcases.h" > + > +struct fake_sigframe sf; > + > +static int fake_sigreturn_duplicated_fpsimd_run(struct tdescr *td, > + siginfo_t *si, ucontext_t *uc) > +{ > + struct _aarch64_ctx *shead = GET_SF_RESV_HEAD(sf), *head; > + > + /* just to fill the ucontext_t with something real */ > + if (!get_current_context(td, &sf.uc)) > + return 1; > + > + head = get_starting_head(shead, sizeof(struct fpsimd_context) + HDR_SZ, > + GET_SF_RESV_SIZE(sf), NULL); > + if (!head) > + return 0; > + > + /* Add a spurios fpsimd_context */ Nit: spurious With that, Reviewed-by: Dave Martin [...] Cheers ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel