Re: [PATCH v3 1/2] dt-bindings: Add binding for IT6505.

[Rob Herring <robh@kernel.org>]

On Thu, Sep 12, 2019 at 11:32:28AM +0800, allen wrote:
> From: Allen Chen <allen.chen@ite.com.tw>
> 
> Add a DT binding documentation for IT6505.
> 
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
> 

Drop the blank line.

> Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
> 
> ---
> cros-ec does not have an associated driver that uses the standard Linux USB-C driver class.
> extcon is used to model the Type-C connector.(crbug.com/982932)
> ---
>  .../bindings/display/bridge/ite,it6505.txt         | 28 ++++++++++++++++++++++
>  .../devicetree/bindings/vendor-prefixes.yaml       |  2 ++
>  2 files changed, 30 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/bridge/ite,it6505.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt b/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt
> new file mode 100644
> index 0000000..72da0c4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt
> @@ -0,0 +1,28 @@
> +iTE it6505 DP bridge bindings
> +
> +Required properties:
> +        - compatible: "ite,it6505"
> +        - reg: i2c address of the bridge
> +        - ovdd-supply: I/O voltage
> +        - pwr18-supply: Core voltage
> +        - interrupts: interrupt specifier of INT pin
> +        - reset-gpios: gpio specifier of RESET pin
> +	- hpd-gpios:
> +		Hotplug detect GPIO.
> +		Indicates which GPIO should be used for hotplug detection

This belongs in a dp-connector node.

> +	- port@[x]: SoC specific port nodes with endpoint definitions as defined
> +		in Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt

I assume this bridge works with more than just Mediatek? The port 
definitions need to be in terms of what's the data on each port. 

> +
> +Example:
> +	dp-bridge@5c {
> +                compatible = "ite,it6505";
> +                interrupts = <152 IRQ_TYPE_EDGE_RISING 152 0>;
> +                reg = <0x5c>;
> +                pinctrl-names = "default";
> +                pinctrl-0 = <&it6505_pins>;
> +                ovdd-supply = <&mt6358_vsim1_reg>;
> +                pwr18-supply = <&it6505_pp18_reg>;
> +                reset-gpios = <&pio 179 1>;
> +                hpd-gpios = <&pio 9 0>;
> +                extcon = <&usbc_extcon>;

Not documented and deprecated anyways. Use the connector bindings.

> +        };
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 967e78c..fb3b643 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -461,6 +461,8 @@ patternProperties:
>      description: Intersil
>    "^issi,.*":
>      description: Integrated Silicon Solutions Inc.
> +  "^ite,.*":
> +    description: ITE Tech. Inc.
>    "^itead,.*":
>      description: ITEAD Intelligent Systems Co.Ltd
>    "^iwave,.*":
> -- 
> 1.9.1
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel