All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/libglib2: Do not depend on util-linux
Date: Tue, 17 Sep 2019 22:02:16 +0200	[thread overview]
Message-ID: <20190917220216.3f719f37@windsurf> (raw)
In-Reply-To: <20190916191605.86764-2-aduskett@gmail.com>

On Mon, 16 Sep 2019 12:16:05 -0700
aduskett at gmail.com wrote:

> From: Adam Duskett <Aduskett@gmail.com>
> 
> libglib2 needs util-linux only for libmount, which is a configuration option.
> Instead, check if util-linux-libmount is selected, and if so, set the option
> to true.
> 
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> ---
>  package/libglib2/Config.in   |  2 --
>  package/libglib2/libglib2.mk | 10 +++++++++-
>  2 files changed, 9 insertions(+), 3 deletions(-)

Applied to master, thanks. This may cause problems for people who
currently needed libmount, but do not have anything else in their
configuration that selects util-linux libmount option. Their next
Buildroot build will silently no longer have libmount support.

However, we don't really have a good way to handle such dependencies
that used to be mandatory and become optional, so there's not much we
can do about it.

We might however see a few build issues from reverse dependencies of
libglib2 that do need libmount. Such reverse dependencies will have to
select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT by themselves.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-09-17 20:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-16 19:16 [Buildroot] [PATCH 1/2] package/libglib2: bump to version 2.62.0 aduskett at gmail.com
2019-09-16 19:16 ` [Buildroot] [PATCH 2/2] package/libglib2: Do not depend on util-linux aduskett at gmail.com
2019-09-17 20:02   ` Thomas Petazzoni [this message]
2019-09-17 20:32     ` Carlos Santos
2019-09-17 21:23       ` Thomas Petazzoni
2019-09-17 21:50     ` Arnout Vandecappelle
2019-09-18  7:04       ` Thomas Petazzoni
2019-09-17 20:00 ` [Buildroot] [PATCH 1/2] package/libglib2: bump to version 2.62.0 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190917220216.3f719f37@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.