From: Christoph Hellwig <hch@lst.de>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: remove xfs_release
Date: Wed, 18 Sep 2019 18:49:38 +0200 [thread overview]
Message-ID: <20190918164938.GA19316@lst.de> (raw)
In-Reply-To: <20190916125311.GB41978@bfoster>
On Mon, Sep 16, 2019 at 08:53:11AM -0400, Brian Foster wrote:
> The caller might not care if this call generates errors, but shouldn't
> we care if something fails? IOW, perhaps we should have an exit path
> with a WARN_ON_ONCE() or some such to indicate that an unhandled error
> has occurred..?
Not sure there is much of a point. Basically all errors are either
due to a forced shutdown or cause a forced shutdown anyway, so we'll
already get warnings.
next prev parent reply other threads:[~2019-09-18 16:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 12:20 minor ->release fixups and cleanups Christoph Hellwig
2019-09-16 12:20 ` [PATCH 1/2] xfs: remove xfs_release Christoph Hellwig
2019-09-16 12:53 ` Brian Foster
2019-09-18 16:49 ` Christoph Hellwig [this message]
2019-09-18 18:12 ` Brian Foster
2019-09-18 18:21 ` Darrick J. Wong
2019-09-18 22:25 ` Dave Chinner
2019-09-16 12:20 ` [PATCH 2/2] xfs: shortcut xfs_file_release for read-only file descriptors Christoph Hellwig
2019-09-16 12:53 ` Brian Foster
2019-09-18 16:50 ` Christoph Hellwig
2019-09-18 17:06 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918164938.GA19316@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.