From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Saiyam Doshi <saiyamdoshi.in@gmail.com>
Cc: ludovic.desroches@microchip.com, ulf.hansson@linaro.org,
nicolas.ferre@microchip.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: host: atmel-mci: assign false/true to bool variable
Date: Wed, 18 Sep 2019 20:01:12 +0200 [thread overview]
Message-ID: <20190918180112.GR21254@piout.net> (raw)
In-Reply-To: <20190918172823.GA28786@SD>
Hello,
On 18/09/2019 22:58:23+0530, Saiyam Doshi wrote:
> Use false/true instead of 0/1 in bool variable assignment.
>
> This fixes below coccicheck warning.
> "WARNING: Assignment of 0/1 to bool variable"
>
> Generated by: scripts/coccinelle/misc/boolinit.cocci
>
> More information about semantic patching is available at
> http://coccinelle.lip6.fr/
>
More useful than information than info on semantic patching, it would be
good to have info on why you feel this is necessary.
> Signed-off-by: Saiyam Doshi <saiyamdoshi.in@gmail.com>
> ---
> drivers/mmc/host/atmel-mci.c | 50 ++++++++++++++++++------------------
> 1 file changed, 25 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> index c26fbe5f2222..91088b1712ae 100644
> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -706,7 +706,7 @@ static void atmci_timeout_timer(struct timer_list *t)
> host->mrq->cmd->error = -ETIMEDOUT;
> host->cmd = NULL;
> }
> - host->need_reset = 1;
> + host->need_reset = true;
> host->state = STATE_END_REQUEST;
> smp_wmb();
> tasklet_schedule(&host->tasklet);
> @@ -1610,7 +1610,7 @@ static void atmci_command_complete(struct atmel_mci *host,
> else if (host->mrq->data && (host->mrq->data->blksz & 3)) {
> if (host->caps.need_blksz_mul_4) {
> cmd->error = -EINVAL;
> - host->need_reset = 1;
> + host->need_reset = true;
> }
> } else
> cmd->error = 0;
> @@ -2396,45 +2396,45 @@ static void atmci_get_cap(struct atmel_mci *host)
> dev_info(&host->pdev->dev,
> "version: 0x%x\n", version);
>
> - host->caps.has_dma_conf_reg = 0;
> - host->caps.has_pdc = 1;
> - host->caps.has_cfg_reg = 0;
> - host->caps.has_cstor_reg = 0;
> - host->caps.has_highspeed = 0;
> - host->caps.has_rwproof = 0;
> - host->caps.has_odd_clk_div = 0;
> - host->caps.has_bad_data_ordering = 1;
> - host->caps.need_reset_after_xfer = 1;
> - host->caps.need_blksz_mul_4 = 1;
> - host->caps.need_notbusy_for_read_ops = 0;
> + host->caps.has_dma_conf_reg = false;
> + host->caps.has_pdc = true;
> + host->caps.has_cfg_reg = false;
> + host->caps.has_cstor_reg = false;
> + host->caps.has_highspeed = false;
> + host->caps.has_rwproof = false;
> + host->caps.has_odd_clk_div = false;
> + host->caps.has_bad_data_ordering = true;
> + host->caps.need_reset_after_xfer = true;
> + host->caps.need_blksz_mul_4 = true;
> + host->caps.need_notbusy_for_read_ops = false;
>
> /* keep only major version number */
> switch (version & 0xf00) {
> case 0x600:
> case 0x500:
> - host->caps.has_odd_clk_div = 1;
> + host->caps.has_odd_clk_div = true;
> /* Fall through */
> case 0x400:
> case 0x300:
> - host->caps.has_dma_conf_reg = 1;
> - host->caps.has_pdc = 0;
> - host->caps.has_cfg_reg = 1;
> - host->caps.has_cstor_reg = 1;
> - host->caps.has_highspeed = 1;
> + host->caps.has_dma_conf_reg = true;
> + host->caps.has_pdc = false;
> + host->caps.has_cfg_reg = true;
> + host->caps.has_cstor_reg = true;
> + host->caps.has_highspeed = true;
> /* Fall through */
> case 0x200:
> - host->caps.has_rwproof = 1;
> - host->caps.need_blksz_mul_4 = 0;
> - host->caps.need_notbusy_for_read_ops = 1;
> + host->caps.has_rwproof = true;
> + host->caps.need_blksz_mul_4 = false;
> + host->caps.need_notbusy_for_read_ops = true;
> /* Fall through */
> case 0x100:
> - host->caps.has_bad_data_ordering = 0;
> - host->caps.need_reset_after_xfer = 0;
> + host->caps.has_bad_data_ordering = false;
> + host->caps.need_reset_after_xfer = false;
> /* Fall through */
> case 0x0:
> break;
> default:
> - host->caps.has_pdc = 0;
> + host->caps.has_pdc = false;
> dev_warn(&host->pdev->dev,
> "Unmanaged mci version, set minimum capabilities\n");
> break;
> --
> 2.20.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-09-18 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 17:28 [PATCH] mmc: host: atmel-mci: assign false/true to bool variable Saiyam Doshi
2019-09-18 18:01 ` Alexandre Belloni [this message]
2019-09-22 16:49 ` Saiyam Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918180112.GR21254@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=saiyamdoshi.in@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.