From: Christoph Hellwig <hch@lst.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] x86/mm: Remove set_pages_x() and set_pages_nx()
Date: Wed, 18 Sep 2019 22:56:16 +0200 [thread overview]
Message-ID: <20190918205616.GA23251@lst.de> (raw)
In-Reply-To: <bd5684ee-afaf-a9ba-6c32-15d2aa94733c@lwfinger.net>
On Wed, Sep 18, 2019 at 01:17:13PM -0500, Larry Finger wrote:
> The external module is vboxdrv, which is part of VirtualBox. The setting of
> pages to be executable appears to have been added in kernel 2.4.20.
>
> I am now testing with the former calls to set_pages_x() and set_pages_nx()
> disabled. Thus far, VMs seem to be running OK. I will contact Oracle to
> discuss the matter with them and see if there is some special case that
> requires this facility. If there is one, then they will need to discuss it
> with you and Christoph.
Well, in this case the API is called /dev/kvm. There is really
absolutely no reason for anyone badly reinventing the low-level
VT and SVM code when they can just use the kernel kvm support, which
already has at least half a dozen users.
prev parent reply other threads:[~2019-09-18 20:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 16:41 [PATCH] x86/mm: Remove set_pages_x() and set_pages_nx() Larry Finger
2019-09-18 16:45 ` Christoph Hellwig
2019-09-18 17:49 ` Larry Finger
2019-09-18 17:53 ` Christoph Hellwig
2019-09-18 17:53 ` Linus Torvalds
2019-09-18 18:17 ` Larry Finger
2019-09-18 20:56 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918205616.GA23251@lst.de \
--to=hch@lst.de \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.