From: Jiri Pirko <jiri@resnulli.us>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org,
syzbot+618aacd49e8c8b8486bd@syzkaller.appspotmail.com,
David Ahern <dsahern@gmail.com>,
Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [Patch net] net_sched: add max len check for TCA_KIND
Date: Thu, 19 Sep 2019 08:40:46 +0200 [thread overview]
Message-ID: <20190919064046.GC2187@nanopsycho> (raw)
In-Reply-To: <20190918232412.16718-1-xiyou.wangcong@gmail.com>
Thu, Sep 19, 2019 at 01:24:12AM CEST, xiyou.wangcong@gmail.com wrote:
>The TCA_KIND attribute is of NLA_STRING which does not check
>the NUL char. KMSAN reported an uninit-value of TCA_KIND which
>is likely caused by the lack of NUL.
>
>Change it to NLA_NUL_STRING and add a max len too.
>
>Fixes: 8b4c3cdd9dd8 ("net: sched: Add policy validation for tc attributes")
>Reported-and-tested-by: syzbot+618aacd49e8c8b8486bd@syzkaller.appspotmail.com
Acked-by: Jiri Pirko <jiri@mellanox.com>
prev parent reply other threads:[~2019-09-19 6:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 23:24 [Patch net] net_sched: add max len check for TCA_KIND Cong Wang
2019-09-19 2:41 ` David Ahern
2019-09-19 5:15 ` Cong Wang
2019-09-22 2:24 ` Jakub Kicinski
2019-10-03 19:45 ` Marcelo Ricardo Leitner
2019-10-04 22:54 ` Jakub Kicinski
2019-10-04 23:23 ` Cong Wang
2019-10-04 23:47 ` Jakub Kicinski
2019-09-19 6:40 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919064046.GC2187@nanopsycho \
--to=jiri@resnulli.us \
--cc=dsahern@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=syzbot+618aacd49e8c8b8486bd@syzkaller.appspotmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.