From: Pavel Machek <pavel@ucw.cz>
To: Tony Lindgren <tony@atomide.com>
Cc: Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, linux-omap@vger.kernel.org,
Merlijn Wajer <merlijn@wizzup.org>
Subject: Re: [PATCH 1/3] power: supply: cpcap-charger: Limit voltage to 4.2V for battery
Date: Thu, 19 Sep 2019 11:05:39 +0200 [thread overview]
Message-ID: <20190919090539.GA9644@amd> (raw)
In-Reply-To: <20190917213501.16907-2-tony@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 1213 bytes --]
On Tue 2019-09-17 14:34:59, Tony Lindgren wrote:
> From: Pavel Machek <pavel@ucw.cz>
>
> There have been some cases of droid4 battery bulging that seem to
> be related to being left connected to the charger for several weeks.
>
> It is suspected that the 4.35V charge voltage configured for the battery
> is too much in the long run, so lets limit the charge voltage to 4.2V.
4.35V is known to make lifetime of battery shorter, but it provides
10% more capacity.
Disadvantage of this approach is that if droid is rebooted between
mainline and android, battery will go 4.35V->4.2V->4.35V... while on
charger.
I guess this patch still makes sense, I just wanted to make sure
disadvantages are mentioned.
Best regards,
Pavel
> @@ -457,7 +457,7 @@ static void cpcap_usb_detect(struct work_struct *work)
> max_current = CPCAP_REG_CRM_ICHRG_0A532;
>
> error = cpcap_charger_set_state(ddata,
> - CPCAP_REG_CRM_VCHRG_4V35,
> + CPCAP_REG_CRM_VCHRG_4V20,
> max_current, 0);
> if (error)
> goto out_err;
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-09-19 9:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 21:34 [PATCH 0/3] cpcap charger and battery fixes Tony Lindgren
2019-09-17 21:34 ` [PATCH 1/3] power: supply: cpcap-charger: Limit voltage to 4.2V for battery Tony Lindgren
2019-09-19 9:05 ` Pavel Machek [this message]
2019-09-20 14:03 ` Tony Lindgren
2019-09-17 21:35 ` [PATCH 2/3] power: supply: cpcap-battery: Check voltage before orderly_poweroff Tony Lindgren
2019-09-19 9:14 ` Pavel Machek
2019-09-20 14:12 ` Tony Lindgren
2019-09-22 18:00 ` Tony Lindgren
2019-09-17 21:35 ` [PATCH 3/3] power: supply: cpcap-charger: Improve battery detection Tony Lindgren
2019-09-19 9:19 ` Pavel Machek
2019-09-20 14:18 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919090539.GA9644@amd \
--to=pavel@ucw.cz \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.