From: Kees Cook <keescook@chromium.org>
To: Tim.Bird@sony.com
Cc: shuah@kernel.org, anders.roxell@linaro.org,
alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests/kselftest/runner.sh: Add 45 second timeout per test
Date: Thu, 19 Sep 2019 13:58:53 -0700 [thread overview]
Message-ID: <201909191357.7B79D5D427@keescook> (raw)
In-Reply-To: <ECADFF3FD767C149AD96A924E7EA6EAF977BA66E@USCULXMSG01.am.sony.com>
On Thu, Sep 19, 2019 at 08:49:14PM +0000, Tim.Bird@sony.com wrote:
> > > +export timeout_rc=124
> > what are the units here? I presume seconds?
>
> Nevermind. I misread this. This is the return code from the 'timeout' program, right?
Correct -- given the skip_rc usage, it felt weird to hard-code it in the
if/else statements.
As for the "45" I chose, that was just to be "more than 30" which was
the per-sub-test for tests built using kselftest_harness.h.
--
Kees Cook
next prev parent reply other threads:[~2019-09-19 20:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 18:06 [PATCH] selftests/kselftest/runner.sh: Add 45 second timeout per test Kees Cook
2019-09-19 18:55 ` Alexandre Belloni
2019-09-19 20:09 ` shuah
2019-09-19 20:47 ` Tim.Bird
2019-09-19 21:17 ` Kees Cook
2019-09-20 20:24 ` shuah
2019-09-19 20:41 ` Tim.Bird
2019-09-19 20:49 ` Tim.Bird
2019-09-19 20:58 ` Kees Cook [this message]
2019-09-19 21:11 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201909191357.7B79D5D427@keescook \
--to=keescook@chromium.org \
--cc=Tim.Bird@sony.com \
--cc=alexandre.belloni@bootlin.com \
--cc=anders.roxell@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.